Fix alpha writes while rendering to texture.

Author: chinmaygarde

impeller/aiks/aiks_unittests.cc

@@ -56,7 +56,7 @@ TEST_F(AiksTest, CanRenderImage) {
   auto image = std::make_shared<Image>(CreateTextureForFixture("kalimba.jpg"));
   paint.color = Color::Red();
   canvas.DrawImage(image, Point::MakeXY(100.0, 100.0), paint);
-  // ASSERT_TRUE(OpenPlaygroundHere(canvas.EndRecordingAsPicture()));
+  ASSERT_TRUE(OpenPlaygroundHere(canvas.EndRecordingAsPicture()));
 }
 
 TEST_F(AiksTest, DISABLED_CanRenderImageRect) {
@@ -122,8 +122,8 @@ TEST_F(AiksTest, CanRenderGroupOpacity) {
   canvas.SaveLayer(alpha);
 
   canvas.DrawRect({000, 000, 100, 100}, red);
-  // canvas.DrawRect({020, 020, 100, 100}, green);
-  // canvas.DrawRect({040, 040, 100, 100}, blue);
+  canvas.DrawRect({020, 020, 100, 100}, green);
+  canvas.DrawRect({040, 040, 100, 100}, blue);
 
   canvas.Restore();
 

impeller/aiks/canvas_pass.cc

@@ -104,6 +104,8 @@ bool CanvasPass::Render(ContentRenderer& renderer,
 
     auto sub_command_buffer = context->CreateRenderCommandBuffer();
 
+    sub_command_buffer->SetLabel("Offscreen Command Buffer");
+
     if (!sub_command_buffer) {
       return false;
     }
@@ -124,7 +126,9 @@ bool CanvasPass::Render(ContentRenderer& renderer,
       return false;
     }
 
-    sub_command_buffer->SubmitCommands();
+    if (!sub_command_buffer->SubmitCommands()) {
+      return false;
+    }
 
     auto offscreen_texture_contents = std::make_shared<TextureContents>();
     offscreen_texture_contents->SetTexture(

impeller/entity/contents.cc

@@ -87,8 +87,8 @@ bool LinearGradientContents::Render(const ContentRenderer& renderer,
   cmd.label = "LinearGradientFill";
   cmd.pipeline = renderer.GetGradientFillPipeline();
   cmd.stencil_reference = entity.GetStencilDepth();
-  cmd.BindVertices(vertices_builder.CreateVertexBuffer(
-      *renderer.GetContext()->GetPermanentsAllocator()));
+  cmd.BindVertices(
+      vertices_builder.CreateVertexBuffer(pass.GetTransientsBuffer()));
   cmd.primitive_type = PrimitiveType::kTriangle;
   FS::BindGradientInfo(
       cmd, pass.GetTransientsBuffer().EmplaceUniform(gradient_info));

impeller/entity/shaders/texture_fill.frag

@@ -9,5 +9,6 @@ in vec2 v_texture_coords;
 out vec4 frag_color;
 
 void main() {
-  frag_color = texture(texture_sampler, v_texture_coords);
+  vec4 sampled = texture(texture_sampler, v_texture_coords);
+  frag_color = sampled;
 }

impeller/geometry/size.h

@@ -33,10 +33,15 @@ struct TSize {
                  std::numeric_limits<Type>::max()};
   }
 
-  constexpr TSize operator*(Type scale) const {
+  constexpr TSize operator*(Scalar scale) const {
     return {width * scale, height * scale};
   }
 
+  constexpr TSize operator/(Scalar scale) const {
+    return {static_cast<Scalar>(width) / scale,
+            static_cast<Scalar>(height) / scale};
+  }
+
   constexpr bool operator==(const TSize& s) const {
     return s.width == width && s.height == height;
   }

impeller/renderer/backend/metal/command_buffer_mtl.h

@@ -26,11 +26,14 @@ class CommandBufferMTL final : public CommandBuffer {
 
   CommandBufferMTL(id<MTLCommandQueue> queue);
 
+  // |CommandBuffer|
+  void SetLabel(const std::string& label) const override;
+
   // |CommandBuffer|
   bool IsValid() const override;
 
   // |CommandBuffer|
-  void SubmitCommands(CompletionCallback callback) override;
+  bool SubmitCommands(CompletionCallback callback) override;
 
   // |CommandBuffer|
   void ReserveSpotInQueue() override;

impeller/renderer/backend/metal/command_buffer_mtl.mm

@@ -22,6 +22,14 @@
   return is_valid_;
 }
 
+void CommandBufferMTL::SetLabel(const std::string& label) const {
+  if (label.empty()) {
+    return;
+  }
+
+  [buffer_ setLabel:@(label.data())];
+}
+
 static CommandBuffer::Status ToCommitResult(MTLCommandBufferStatus status) {
   switch (status) {
     case MTLCommandBufferStatusCompleted:
@@ -34,13 +42,13 @@
   return CommandBufferMTL::Status::kError;
 }
 
-void CommandBufferMTL::SubmitCommands(CompletionCallback callback) {
+bool CommandBufferMTL::SubmitCommands(CompletionCallback callback) {
   if (!buffer_) {
     // Already committed. This is caller error.
     if (callback) {
       callback(Status::kError);
     }
-    return;
+    return false;
   }
 
   if (callback) {
@@ -51,6 +59,7 @@
 
   [buffer_ commit];
   buffer_ = nil;
+  return true;
 }
 
 void CommandBufferMTL::ReserveSpotInQueue() {

impeller/renderer/command_buffer.cc

@@ -10,8 +10,8 @@ CommandBuffer::CommandBuffer() = default;
 
 CommandBuffer::~CommandBuffer() = default;
 
-void CommandBuffer::SubmitCommands() {
-  SubmitCommands(nullptr);
+bool CommandBuffer::SubmitCommands() {
+  return SubmitCommands(nullptr);
 }
 
 }  // namespace impeller

impeller/renderer/command_buffer.h

@@ -41,6 +41,8 @@ class CommandBuffer {
 
   virtual bool IsValid() const = 0;
 
+  virtual void SetLabel(const std::string& label) const = 0;
+
   //----------------------------------------------------------------------------
   /// @brief      Schedule the command encoded by render passes within this
   ///             command buffer on the GPU.
@@ -49,9 +51,9 @@ class CommandBuffer {
   ///
   /// @param[in]  callback  The completion callback.
   ///
-  virtual void SubmitCommands(CompletionCallback callback) = 0;
+  [[nodiscard]] virtual bool SubmitCommands(CompletionCallback callback) = 0;
 
-  void SubmitCommands();
+  [[nodiscard]] bool SubmitCommands();
 
   virtual void ReserveSpotInQueue() = 0;
 

impeller/renderer/formats.h

@@ -138,7 +138,7 @@ enum class ColorWriteMask : uint64_t {
   kGreen = 1 << 1,
   kBlue = 1 << 2,
   kAlpha = 1 << 3,
-  kAll = kRed | kGreen | kBlue,
+  kAll = kRed | kGreen | kBlue | kAlpha,
 };
 
 constexpr size_t BytesPerPixelForPixelFormat(PixelFormat format) {
@@ -163,7 +163,7 @@ constexpr size_t BytesPerPixelForPixelFormat(PixelFormat format) {
 /// @brief      Describe the color attachment that will be used with this
 ///             pipeline.
 ///
-/// Blending at specific color attachments follows the pseudocode:
+/// Blending at specific color attachments follows the pseudo-code:
 /// ```
 /// if (blending_enabled) {
 ///   final_color.rgb = (src_color_blend_factor * new_color.rgb)
@@ -248,7 +248,7 @@ enum class StencilOperation {
   kDecrementClamp,
   /// Perform a logical bitwise invert on the current stencil value.
   kInvert,
-  /// Increment the current stencil value by 1. If at maxium, set to zero.
+  /// Increment the current stencil value by 1. If at maximum, set to zero.
   kIncrementWrap,
   /// Decrement the current stencil value by 1. If at zero, set to maximum.
   kDecrementWrap,