Skip to content

feat: add ipc channel in nonDaemon mode #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

XadillaX
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@XadillaX XadillaX requested a review from popomore August 22, 2018 10:45
@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files           6        6           
  Lines         207      207           
=======================================
  Hits          206      206           
  Misses          1        1
Impacted Files Coverage Δ
lib/cmd/start.js 99.17% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262ef4c...ecb1fdd. Read the comment docs.

@popomore
Copy link
Member

@atian25 我们这个 win 测试是能过的?

@popomore popomore merged commit 1367883 into eggjs:master Aug 23, 2018
@popomore
Copy link
Member

@atian25
Copy link
Member

atian25 commented Aug 23, 2018

@popomore 之前是没开 win 测试的,在 #22 里面才开的好像

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants