Break up some especially long lines (Fortitude/S001)

Long lines are more difficult to read, and may not fit on some developers'
terminals. The line continuation character '&' may be used to split a long line
across multiple lines, and overly long expressions may be broken down into
multiple parts.

The maximum line length can be changed using the flag `--line-length=N`. The
default maximum line length is 100 characters. This is a fair bit more than the
traditional 80, but due to the verbosity of modern Fortran it can sometimes be
difficult to squeeze lines into that width, especially when using large indents
and multiple levels of indentation.

Some lines that are longer than the maximum length may be acceptable, such as
long strings or comments. This is to allow for long URLs or other text that cannot
be reasonably split across multiple lines.

Note that the Fortran standard states a maximum line length of 132 characters,
and while some modern compilers will support longer lines, for portability it
is recommended to stay beneath this limit.

Author: samhatfield

src/programs/util/ectrans_memory.F90

@@ -114,7 +114,8 @@ subroutine c_set_logging(logging) bind(c,name="ectrans_memory_set_logging")
         integer(c_int), value :: logging
     end subroutine
 
-    subroutine c_set_logging_fortran_output_unit(output_unit) bind(c, name="ectrans_memory_set_logging_fortran_output_unit")
+    subroutine c_set_logging_fortran_output_unit(output_unit) bind(c, &
+          & name="ectrans_memory_set_logging_fortran_output_unit")
         use iso_c_binding, only: c_int
         integer(c_int), value :: output_unit
     end subroutine

src/trans/cpu/internal/suleg_mod.F90

@@ -338,7 +338,8 @@ SUBROUTINE SULEG
   IF( LLP2 ) THEN
     WRITE(NOUT,*) 'dual latitudes'
     DO JGL= 1, INN
-      WRITE(NOUT,*)  'dual  JGL=',JGL,(180._JPRD/ZPI)*ZINC,(180._JPRD/ZPI)*ASIN(ZLRMUZ2(JGL)),(180._JPRD/ZPI)*ASIN(F%RMU(JGL))
+      WRITE(NOUT,*)  'dual  JGL=',JGL,(180._JPRD/ZPI)*ZINC,(180._JPRD/ZPI)*ASIN(ZLRMUZ2(JGL)),&
+        & (180._JPRD/ZPI)*ASIN(F%RMU(JGL))
     ENDDO
   ENDIF
 

src/trans/gpu/algor/ext_acc.F90

@@ -41,7 +41,8 @@ module openacc_ext
   end type
 
   interface ext_acc_pass
-    module procedure ext_acc_pass_2d_r4, ext_acc_pass_3d_r4, ext_acc_pass_4d_r4, ext_acc_pass_2d_r8, ext_acc_pass_3d_r8, ext_acc_pass_4d_r8
+    module procedure ext_acc_pass_2d_r4, ext_acc_pass_3d_r4, ext_acc_pass_4d_r4
+    module procedure ext_acc_pass_2d_r8, ext_acc_pass_3d_r8, ext_acc_pass_4d_r8
   end interface
 contains
 

src/trans/gpu/external/setup_trans.F90

@@ -381,7 +381,8 @@ SUBROUTINE SETUP_TRANS(KSMAX,KDGL,KDLON,KLOEN,LDSPLIT,PSTRET,&
   IF (D%LGRIDONLY) THEN
       R%NSMAX=1
       R%NTMAX = R%NSMAX
-      WRITE(NOUT,'(A,I0)') "DEVELOPER WARNING: LDGRIDONLY IS NOT YET IMPLEMENTED CORRECTLY WITH GPU BACKEND. IGNORE AND USE TRUNCATION: ", R%NSMAX
+      WRITE(NOUT,'(A,I0)') "DEVELOPER WARNING: LDGRIDONLY IS NOT YET IMPLEMENTED CORRECTLY WITH GPU&
+        & BACKEND. IGNORE AND USE TRUNCATION: ", R%NSMAX
       D%LGRIDONLY = .FALSE.
   ENDIF
 ! >>>>>>>>>>>>>

src/trans/gpu/internal/fsc_mod.F90

@@ -73,7 +73,8 @@ SUBROUTINE FSC(ALLOCATOR,HFSC,PREEL_COMPLEX, KF_FS, KF_UV, KF_SCALARS, KUV_OFFSE
 IMPLICIT NONE
 REAL(KIND=JPRBT), INTENT(INOUT) :: PREEL_COMPLEX(:)
 INTEGER(KIND=JPIM), INTENT(IN) :: KF_FS, KF_UV, KF_SCALARS
-INTEGER(KIND=JPIM), INTENT(IN) :: KUV_OFFSET, KSCALARS_OFFSET, KSCALARS_NSDER_OFFSET, KUV_EWDER_OFFSET, KSCALARS_EWDER_OFFSET
+INTEGER(KIND=JPIM), INTENT(IN) :: KUV_OFFSET, KSCALARS_OFFSET, KSCALARS_NSDER_OFFSET
+INTEGER(KIND=JPIM), INTENT(IN) :: KUV_EWDER_OFFSET, KSCALARS_EWDER_OFFSET
 TYPE(BUFFERED_ALLOCATOR), INTENT(IN) :: ALLOCATOR
 TYPE(FSC_HANDLE), INTENT(IN) :: HFSC
 

src/trans/gpu/internal/fscad_mod.F90

@@ -74,7 +74,8 @@ SUBROUTINE FSCAD(ALLOCATOR,HFSC,PREEL_COMPLEX, KF_FS, KF_UV, KF_SCALARS, KUV_OFF
 IMPLICIT NONE
 REAL(KIND=JPRBT), INTENT(INOUT) :: PREEL_COMPLEX(:)
 INTEGER(KIND=JPIM), INTENT(IN) :: KF_FS, KF_UV, KF_SCALARS
-INTEGER(KIND=JPIM), INTENT(IN) :: KUV_OFFSET, KSCALARS_OFFSET, KSCALARS_NSDER_OFFSET, KUV_EWDER_OFFSET, KSCALARS_EWDER_OFFSET
+INTEGER(KIND=JPIM), INTENT(IN) :: KUV_OFFSET, KSCALARS_OFFSET, KSCALARS_NSDER_OFFSET
+INTEGER(KIND=JPIM), INTENT(IN) :: KUV_EWDER_OFFSET, KSCALARS_EWDER_OFFSET
 TYPE(BUFFERED_ALLOCATOR), INTENT(IN) :: ALLOCATOR
 TYPE(FSCAD_HANDLE), INTENT(IN) :: HFSC
 

src/trans/gpu/internal/suleg_mod.F90

@@ -330,7 +330,8 @@ SUBROUTINE SULEG
   IF( LLP2 ) THEN
     WRITE(NOUT,*) 'dual latitudes'
     DO JGL= 1, INN
-      WRITE(NOUT,*)  'dual  JGL=',JGL,(180._JPRD/ZPI)*ZINC,(180._JPRD/ZPI)*ASIN(ZLRMUZ2(JGL)),(180._JPRD/ZPI)*ASIN(F%RMU(JGL))
+      WRITE(NOUT,*)  'dual  JGL=',JGL,(180._JPRD/ZPI)*ZINC,(180._JPRD/ZPI)*ASIN(ZLRMUZ2(JGL)),&
+        & (180._JPRD/ZPI)*ASIN(F%RMU(JGL))
     ENDDO
   ENDIF
 

src/trans/gpu/internal/trltomad_pack_unpack.F90

@@ -43,7 +43,8 @@ FUNCTION PREPARE_TRLTOMAD_PACK(ALLOCATOR, KF_FS) RESULT(HTRLTOM_PACK)
 
     REAL(KIND=JPRBT) :: DUMMY
 
-    HTRLTOM_PACK%HREEL_COMPLEX = RESERVE(ALLOCATOR, 1_JPIB*KF_FS*D%NLENGTF*C_SIZEOF(DUMMY), "HTRLTOMAD_PACK%HREEL_COMPLEX")
+    HTRLTOM_PACK%HREEL_COMPLEX = RESERVE(ALLOCATOR, 1_JPIB*KF_FS*D%NLENGTF*C_SIZEOF(DUMMY), &
+      & "HTRLTOMAD_PACK%HREEL_COMPLEX")
   END FUNCTION PREPARE_TRLTOMAD_PACK
 
   SUBROUTINE TRLTOMAD_PACK(ALLOCATOR,HTRLTOM_PACK,PREEL_COMPLEX,FOUBUF_IN,KF_FS)

src/trans/gpu/internal/vdtuvad_mod.F90

@@ -130,18 +130,28 @@ SUBROUTINE VDTUVAD(KFIELD,PEPSNM,PVOR,PDIV,PU,PV)
       IF(KM /= 0 .AND. JN >= KM) THEN
         ! (DO JN=KN,R_NTMAX)
 
-        PDIV(II,JI,KMLOC) = -(JN)*PEPSNM(KMLOC,JN+1)*F_RLAPIN(JN)*PV(II,JI-1,KMLOC) - ZKM*F_RLAPIN(JN)*PU(IR,JI,KMLOC) + (JN+1)*PEPSNM(KMLOC,JN)*F_RLAPIN(JN)*PV(II,JI+1,KMLOC)
-        PDIV(IR,JI,KMLOC) = -(JN)*PEPSNM(KMLOC,JN+1)*F_RLAPIN(JN)*PV(IR,JI-1,KMLOC) + ZKM*F_RLAPIN(JN)*PU(II,JI,KMLOC) + (JN+1)*PEPSNM(KMLOC,JN)*F_RLAPIN(JN)*PV(IR,JI+1,KMLOC)
-        PVOR(II,JI,KMLOC) = +(JN)*PEPSNM(KMLOC,JN+1)*F_RLAPIN(JN)*PU(II,JI-1,KMLOC) - ZKM*F_RLAPIN(JN)*PV(IR,JI,KMLOC) - (JN+1)*PEPSNM(KMLOC,JN)*F_RLAPIN(JN)*PU(II,JI+1,KMLOC)
-        PVOR(IR,JI,KMLOC) = +(JN)*PEPSNM(KMLOC,JN+1)*F_RLAPIN(JN)*PU(IR,JI-1,KMLOC) + ZKM*F_RLAPIN(JN)*PV(II,JI,KMLOC) - (JN+1)*PEPSNM(KMLOC,JN)*F_RLAPIN(JN)*PU(IR,JI+1,KMLOC)
+        PDIV(II,JI,KMLOC) = -(JN)*PEPSNM(KMLOC,JN+1)*F_RLAPIN(JN)*PV(II,JI-1,KMLOC) - &
+          & ZKM*F_RLAPIN(JN)*PU(IR,JI,KMLOC) + &
+          & (JN+1)*PEPSNM(KMLOC,JN)*F_RLAPIN(JN)*PV(II,JI+1,KMLOC)
+        PDIV(IR,JI,KMLOC) = -(JN)*PEPSNM(KMLOC,JN+1)*F_RLAPIN(JN)*PV(IR,JI-1,KMLOC) + &
+          & ZKM*F_RLAPIN(JN)*PU(II,JI,KMLOC) + &
+          & (JN+1)*PEPSNM(KMLOC,JN)*F_RLAPIN(JN)*PV(IR,JI+1,KMLOC)
+        PVOR(II,JI,KMLOC) = +(JN)*PEPSNM(KMLOC,JN+1)*F_RLAPIN(JN)*PU(II,JI-1,KMLOC) - &
+          & ZKM*F_RLAPIN(JN)*PV(IR,JI,KMLOC) - &
+          & (JN+1)*PEPSNM(KMLOC,JN)*F_RLAPIN(JN)*PU(II,JI+1,KMLOC)
+        PVOR(IR,JI,KMLOC) = +(JN)*PEPSNM(KMLOC,JN+1)*F_RLAPIN(JN)*PU(IR,JI-1,KMLOC) + &
+          & ZKM*F_RLAPIN(JN)*PV(II,JI,KMLOC) - &
+          & (JN+1)*PEPSNM(KMLOC,JN)*F_RLAPIN(JN)*PU(IR,JI+1,KMLOC)
 
       ELSEIF(KM == 0) THEN
         ! (DO JN=0,R_NTMAX)
 
         PVOR(II,JI,KMLOC) = 0.0_JPRB
-        PVOR(IR,JI,KMLOC) = +(JN)*PEPSNM(KMLOC,JN+1)*F_RLAPIN(JN)*PU(IR,JI-1,KMLOC) - (JN+1)*PEPSNM(KMLOC,JN)*F_RLAPIN(JN)*PU(IR,JI+1,KMLOC)
+        PVOR(IR,JI,KMLOC) = +(JN)*PEPSNM(KMLOC,JN+1)*F_RLAPIN(JN)*PU(IR,JI-1,KMLOC) - &
+          & (JN+1)*PEPSNM(KMLOC,JN)*F_RLAPIN(JN)*PU(IR,JI+1,KMLOC)
         PDIV(II,JI,KMLOC) = 0.0_JPRB
-        PDIV(IR,JI,KMLOC) = -(JN)*PEPSNM(KMLOC,JN+1)*F_RLAPIN(JN)*PV(IR,JI-1,KMLOC) + (JN+1)*PEPSNM(KMLOC,JN)*F_RLAPIN(JN)*PV(IR,JI+1,KMLOC)
+        PDIV(IR,JI,KMLOC) = -(JN)*PEPSNM(KMLOC,JN+1)*F_RLAPIN(JN)*PV(IR,JI-1,KMLOC) + &
+          & (JN+1)*PEPSNM(KMLOC,JN)*F_RLAPIN(JN)*PV(IR,JI+1,KMLOC)
       ENDIF
     ENDDO
   ENDDO

src/transi/transi_module.F90

@@ -446,7 +446,8 @@ subroutine transi_free(ptr) bind(C,name="transi_free")
     use, intrinsic :: iso_c_binding, only: c_ptr
     type(c_ptr), intent(in) :: ptr
   end subroutine transi_free
-  subroutine transi_disable_DR_HOOK_ASSERT_MPI_INITIALIZED() bind(C,name="transi_disable_DR_HOOK_ASSERT_MPI_INITIALIZED")
+  subroutine transi_disable_DR_HOOK_ASSERT_MPI_INITIALIZED() bind(C, &
+    & name="transi_disable_DR_HOOK_ASSERT_MPI_INITIALIZED")
   end subroutine
 end interface