Skip to content

Commit 25e1d5e

Browse files
Apply suggestions from code review
Co-authored-by: Stefan Dirix <[email protected]>
1 parent 2147d8a commit 25e1d5e

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"test": "lerna run test",
1313
"test-cov": "lerna run test-cov",
1414
"lint": "tslint 'packages/**/*.{ts,tsx}' -c ./tslint.json",
15-
"examples-app": "lerna run build && lerna run example:bundle && node packages/examples-app/prepare-examples-app.js"
15+
"build:examples-app": "lerna run build:examples-app && node packages/examples-app/prepare-examples-app.js"
1616
},
1717
"devDependencies": {
1818
"@babel/plugin-proposal-nullish-coalescing-operator": "^7.16.5",

packages/examples-app/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ JSON Forms eliminates the tedious task of writing fully-featured forms by hand b
88

99
This package aggregates JSON Forms examples and makes them reachable via single `index.html` file.
1010

11-
Aggregating the examples assumes that packages were built and their e examples bundled.
11+
Aggregating the examples assumes that packages were built and their examples bundled.
1212
Afterwards, the examples app can be aggregated with [prepare-examples-app.js](./prepare-examples-app.js) into folder `dist`.

packages/examples-app/prepare-examples-app.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ const __dirname = dirname(__filename);
1111
const distDir = join(__dirname, 'dist');
1212
const packagesDir = join(__dirname, '..');
1313
const examples = {
14-
'react-vanilla': join(packagesDir, 'vanilla', 'example', 'dist'),
15-
'react-material': join(packagesDir, 'material', 'example', 'dist')
14+
'react-vanilla': join(packagesDir, 'vanilla-renderers', 'example', 'dist'),
15+
'react-material': join(packagesDir, 'material-renderers', 'example', 'dist')
1616
}
1717

1818
// Clean and recreate dist dir

packages/material-renderers/rollup.example.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ const config = {
4141
rename: () => 'index.html'
4242
},
4343
{
44-
src: '../example/src/logo.svg',
44+
src: '../examples-react/src/logo.svg',
4545
dest: 'example/dist/assets'
4646
}
4747
]

packages/vanilla-renderers/rollup.example.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ const config = {
4545
rename: () => 'index.html'
4646
},
4747
{
48-
src: '../example/src/logo.svg',
48+
src: '../examples-react/src/logo.svg',
4949
dest: 'example/dist/assets'
5050
}
5151
]

0 commit comments

Comments
 (0)