[vscode] remove proposed API createFileSystemWatcher (#15265)

fixes #15135

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>

Author: rschnekenbu

packages/plugin-ext/src/plugin/file-system-event-service-ext-impl.ts

@@ -163,8 +163,8 @@ export class ExtHostFileSystemEventService implements ExtHostFileSystemEventServ
     // --- file events
 
     createFileSystemWatcher(globPattern: string | IRelativePattern, ignoreCreateEvents?: boolean,
-        ignoreChangeEvents?: boolean, ignoreDeleteEvents?: boolean, excludes?: string[]): vscode.FileSystemWatcher {
-        return new FileSystemWatcher(this._onFileSystemEvent.event, globPattern, ignoreCreateEvents, ignoreChangeEvents, ignoreDeleteEvents, excludes);
+        ignoreChangeEvents?: boolean, ignoreDeleteEvents?: boolean): vscode.FileSystemWatcher {
+        return new FileSystemWatcher(this._onFileSystemEvent.event, globPattern, ignoreCreateEvents, ignoreChangeEvents, ignoreDeleteEvents);
     }
 
     $onFileEvent(events: FileSystemEvents) {

packages/plugin-ext/src/plugin/plugin-context.ts

@@ -286,7 +286,6 @@ import { NotebookDocumentsExtImpl } from './notebook/notebook-documents';
 import { NotebookEditorsExtImpl } from './notebook/notebook-editors';
 import { TestingExtImpl } from './tests';
 import { UriExtImpl } from './uri-ext';
-import { isObject } from '@theia/core';
 import { PluginLogger } from './logger';
 
 export function createAPIObject<T extends Object>(rawObject: T): T {
@@ -688,21 +687,12 @@ export function createAPIFactory(
             onDidStartTerminalShellExecution: Event.None
         };
 
-        function createFileSystemWatcher(pattern: RelativePattern, options?: theia.FileSystemWatcherOptions): theia.FileSystemWatcher;
         function createFileSystemWatcher(pattern: theia.GlobPattern, ignoreCreateEvents?: boolean, ignoreChangeEvents?:
-            boolean, ignoreDeleteEvents?: boolean): theia.FileSystemWatcher;
-        function createFileSystemWatcher(pattern: RelativePattern | theia.GlobPattern,
-            ignoreCreateOrOptions?: theia.FileSystemWatcherOptions | boolean, ignoreChangeEventsBoolean?: boolean, ignoreDeleteEventsBoolean?: boolean): theia.FileSystemWatcher {
-            if (isObject<theia.FileSystemWatcherOptions>(ignoreCreateOrOptions)) {
-                const { ignoreCreateEvents, ignoreChangeEvents, ignoreDeleteEvents, excludes } = (ignoreCreateOrOptions as theia.FileSystemWatcherOptions);
-                return createAPIObject(
-                    extHostFileSystemEvent.createFileSystemWatcher(fromGlobPattern(pattern),
-                        ignoreCreateEvents, ignoreChangeEvents, ignoreDeleteEvents, excludes));
-            } else {
-                return createAPIObject(
-                    extHostFileSystemEvent.createFileSystemWatcher(fromGlobPattern(pattern),
-                        ignoreCreateOrOptions as boolean, ignoreChangeEventsBoolean, ignoreDeleteEventsBoolean));
-            }
+            boolean, ignoreDeleteEvents?: boolean): theia.FileSystemWatcher {
+            return createAPIObject(
+                extHostFileSystemEvent.createFileSystemWatcher(fromGlobPattern(pattern),
+                    ignoreCreateEvents, ignoreChangeEvents, ignoreDeleteEvents));
+
         }
         const workspace: typeof theia.workspace = {
 

packages/plugin/src/theia.d.ts

@@ -23,7 +23,6 @@
 
 import './theia-extra';
 import './theia.proposed.canonicalUriProvider';
-import './theia.proposed.createFileSystemWatcher';
 import './theia.proposed.customEditorMove';
 import './theia.proposed.debugVisualization';
 import './theia.proposed.diffCommand';