Fix MacOS browser menu keybinding display

Author: Colin Grant

packages/core/src/browser/keybinding.ts

@@ -314,9 +314,9 @@ export class KeybindingRegistry {
      * @param keybinding the keybinding
      * @param separator the separator to be used to stringify {@link KeyCode}s that are part of the {@link KeySequence}
      */
-    acceleratorFor(keybinding: common.Keybinding, separator: string = ' '): string[] {
+    acceleratorFor(keybinding: common.Keybinding, separator: string = ' ', asciiOnly = false): string[] {
         const bindingKeySequence = this.resolveKeybinding(keybinding);
-        return this.acceleratorForSequence(bindingKeySequence, separator);
+        return this.acceleratorForSequence(bindingKeySequence, separator, asciiOnly);
     }
 
     /**
@@ -325,8 +325,8 @@ export class KeybindingRegistry {
      * @param keySequence the keysequence
      * @param separator the separator to be used to stringify {@link KeyCode}s that are part of the {@link KeySequence}
      */
-    acceleratorForSequence(keySequence: KeySequence, separator: string = ' '): string[] {
-        return keySequence.map(keyCode => this.acceleratorForKeyCode(keyCode, separator));
+    acceleratorForSequence(keySequence: KeySequence, separator: string = ' ', asciiOnly = false): string[] {
+        return keySequence.map(keyCode => this.acceleratorForKeyCode(keyCode, separator, asciiOnly));
     }
 
     /**
@@ -337,7 +337,9 @@ export class KeybindingRegistry {
      * @param asciiOnly if `true`, no special characters will be substituted into the string returned. Ensures correct keyboard shortcuts in Electron menus.
      */
     acceleratorForKeyCode(keyCode: KeyCode, separator: string = ' ', asciiOnly = false): string {
-        return this.componentsForKeyCode(keyCode, asciiOnly).join(separator);
+        const accelerator = this.componentsForKeyCode(keyCode, asciiOnly).join(separator);
+        console.log('SENTINEL FOR GETTING AN ACCELERATOR', accelerator, new Error());
+        return accelerator;
     }
 
     componentsForKeyCode(keyCode: KeyCode, asciiOnly = false): string[] {

packages/core/src/browser/menu/browser-menu-plugin.ts

@@ -479,7 +479,7 @@ export class MenuCommandRegistry extends PhosphorCommandRegistry {
         // Only consider the first keybinding.
         if (bindings.length) {
             const binding = bindings[0];
-            const keys = keybindingRegistry.acceleratorFor(binding);
+            const keys = keybindingRegistry.acceleratorFor(binding, ' ', true);
             this.addKeyBinding({
                 command: id,
                 keys,