Remove and replace '.' imports (#11142)

Importing from adjacent `index.ts` files can trigger unexpected circular import errors.

Replace those imports by importing from the files that define the symbols instead.
Enable an ESLint rule to catch future offences.

Author: colin-grant-work

configs/errors.eslintrc.json

@@ -139,7 +139,14 @@
     "@theia/runtime-import-check": "error",
     "@theia/shared-dependencies": "error",
     "import/no-extraneous-dependencies": "error",
-    "import/no-dynamic-require": "error"
+    "import/no-dynamic-require": "error",
+    "no-restricted-imports": [
+      "error",
+      ".",
+      "./",
+      "..",
+      "../"
+    ]
   },
   "overrides": [
     {

dev-packages/localization-manager/src/localization-manager.ts

@@ -17,8 +17,7 @@
 import * as chalk from 'chalk';
 import * as fs from 'fs-extra';
 import * as path from 'path';
-import { sortLocalization } from '.';
-import { Localization } from './common';
+import { Localization, sortLocalization } from './common';
 import { deepl, DeeplLanguage, DeeplParameters, isSupportedLanguage, supportedLanguages } from './deepl-api';
 
 export interface LocalizationOptions {

dev-packages/private-re-exports/src/package-re-exports.ts

@@ -17,8 +17,7 @@
 import cp = require('child_process');
 import fs = require('fs');
 import path = require('path');
-import { parseModule } from '.';
-import { PackageJson, ReExportJson } from './utility';
+import { PackageJson, parseModule, ReExportJson } from './utility';
 
 export async function readJson<T = unknown>(jsonPath: string): Promise<T> {
     return JSON.parse(await fs.promises.readFile(jsonPath, 'utf8')) as T;

packages/core/src/browser/preferences/injectable-preference-proxy.ts

@@ -17,10 +17,11 @@
 import { inject, injectable, postConstruct } from 'inversify';
 import { PreferenceSchema } from '../../common/preferences/preference-schema';
 import { Disposable, DisposableCollection, Emitter, Event, MaybePromise } from '../../common';
-import { PreferenceChangeEvent, PreferenceEventEmitter, PreferenceProxyOptions, PreferenceRetrieval } from './preference-proxy';
-import { PreferenceChange, PreferenceScope, PreferenceService } from './preference-service';
-import { OverridePreferenceName, PreferenceChangeImpl, PreferenceChanges, PreferenceProviderDataChange, PreferenceProxy } from '.';
+import { PreferenceChangeEvent, PreferenceEventEmitter, PreferenceProxy, PreferenceProxyOptions, PreferenceRetrieval } from './preference-proxy';
+import { PreferenceChange, PreferenceChangeImpl, PreferenceChanges, PreferenceScope, PreferenceService } from './preference-service';
 import { JSONValue } from '@phosphor/coreutils';
+import { PreferenceProviderDataChange } from './preference-provider';
+import { OverridePreferenceName } from './preference-language-override-service';
 
 export const PreferenceProxySchema = Symbol('PreferenceProxySchema');
 export interface PreferenceProxyFactory {

packages/core/src/browser/preferences/preference-proxy.spec.ts

@@ -43,7 +43,7 @@ process.on('unhandledRejection', (reason, promise) => {
 });
 
 import { expect } from 'chai';
-import { PreferenceValidationService } from '.';
+import { PreferenceValidationService } from './preference-validation-service';
 import { JSONValue } from '@phosphor/coreutils';
 let testContainer: Container;
 

packages/core/src/browser/preferences/test/mock-preference-provider.ts

@@ -17,7 +17,7 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
 
 import { interfaces } from 'inversify';
-import { PreferenceProvider } from '../';
+import { PreferenceProvider } from '../preference-provider';
 import { PreferenceScope } from '../preference-scope';
 
 export class MockPreferenceProvider extends PreferenceProvider {

packages/core/src/browser/preferences/test/mock-preference-service.ts

@@ -15,11 +15,11 @@
 // *****************************************************************************
 
 import { injectable } from 'inversify';
-import { PreferenceService, PreferenceChange, OverridePreferenceName } from '../';
 import { Emitter, Event } from '../../../common';
 import URI from '../../../common/uri';
-import { PreferenceChanges, PreferenceInspection } from '../preference-service';
+import { PreferenceChange, PreferenceChanges, PreferenceInspection, PreferenceService } from '../preference-service';
 import { PreferenceScope } from '../preference-scope';
+import { OverridePreferenceName } from '../preference-language-override-service';
 
 @injectable()
 export class MockPreferenceService implements PreferenceService {

packages/core/src/browser/quick-input/quick-view-service.ts

@@ -15,10 +15,10 @@
 // *****************************************************************************
 
 import { inject, injectable } from 'inversify';
-import { filterItems, QuickPickItem, QuickPicks } from '..';
 import { CancellationToken, Disposable } from '../../common';
 import { ContextKeyService } from '../context-key-service';
 import { QuickAccessContribution, QuickAccessProvider, QuickAccessRegistry } from './quick-access';
+import { filterItems, QuickPickItem, QuickPicks } from './quick-input-service';
 
 export interface QuickViewItem {
     readonly label: string;

packages/core/src/common/uri-command-handler.spec.ts

@@ -15,7 +15,7 @@
 // *****************************************************************************
 
 import * as chai from 'chai';
-import { SelectionService } from '.';
+import { SelectionService } from './selection-service';
 import { MaybeArray } from './types';
 import URI from './uri';
 import { UriAwareCommandHandler, UriCommandHandler } from './uri-command-handler';

packages/core/src/common/uri-command-handler.ts

@@ -19,8 +19,8 @@
 import { SelectionService } from '../common/selection-service';
 import { UriSelection } from '../common/selection';
 import { CommandHandler } from './command';
-import { MaybeArray } from '.';
 import URI from './uri';
+import { MaybeArray } from './types';
 
 export interface UriCommandHandler<T extends MaybeArray<URI>> extends CommandHandler {