Deprioritize file resource resolver to avoid resolution delays (#14917)

Introduce optional `priority` field on resource resolvers

Author: colin-grant-work

packages/core/src/common/resource.ts

@@ -14,7 +14,7 @@
 // SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0
 // *****************************************************************************
 
-import { injectable, inject, named } from 'inversify';
+import { injectable, inject, named, postConstruct } from 'inversify';
 import { TextDocumentContentChangeEvent } from 'vscode-languageserver-protocol';
 import URI from '../common/uri';
 import { ContributionProvider } from './contribution-provider';
@@ -178,6 +178,11 @@ export namespace ResourceError {
 
 export const ResourceResolver = Symbol('ResourceResolver');
 export interface ResourceResolver {
+    /**
+     * Resolvers will be ordered by descending priority.
+     * Default: 0
+     */
+    priority?: number;
     /**
      * Reject if a resource cannot be provided.
      */
@@ -195,6 +200,11 @@ export class DefaultResourceProvider {
         protected readonly resolversProvider: ContributionProvider<ResourceResolver>
     ) { }
 
+    @postConstruct()
+    init(): void {
+        this.resolversProvider.getContributions().sort((a, b) => (b.priority ?? 0) - (a.priority ?? 0));
+    }
+
     /**
      * Reject if a resource cannot be provided.
      */

packages/filesystem/src/browser/file-resource.ts

@@ -334,6 +334,8 @@ export class FileResource implements Resource {
 
 @injectable()
 export class FileResourceResolver implements ResourceResolver {
+    /** This resolver interacts with the VSCode plugin system in a way that can cause delays. Most other resource resolvers fail immediately, so this one should be tried late. */
+    readonly priority = -10;
 
     @inject(FileService)
     protected readonly fileService: FileService;