Skip to content

Commit 66057be

Browse files
committed
Fix more tests
Signed-off-by: Thomas Mäder <[email protected]>
1 parent f820626 commit 66057be

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

examples/api-tests/src/monaco-api.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,11 +177,11 @@ describe('Monaco API', async function () {
177177
const key = 'monaco-api-test-context';
178178
const firstValue = 'first setting';
179179
const secondValue = 'second setting';
180-
assert.isFalse(contextKeys.match(`${key} == ${firstValue}`));
180+
assert.isFalse(contextKeys.match(`${key} == '${firstValue}'`));
181181
await commands.executeCommand(setContext, key, firstValue);
182-
assert.isTrue(contextKeys.match(`${key} == ${firstValue}`));
182+
assert.isTrue(contextKeys.match(`${key} == '${firstValue}'`));
183183
await commands.executeCommand(setContext, key, secondValue);
184-
assert.isTrue(contextKeys.match(`${key} == ${secondValue}`));
184+
assert.isTrue(contextKeys.match(`${key} == '${secondValue}'`));
185185
});
186186

187187
it('Supports context key: inQuickOpen', async () => {

examples/api-tests/src/typescript.spec.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -688,11 +688,10 @@ SPAN {
688688
editor.getControl().revealPosition({ lineNumber, column });
689689
assert.equal(currentChar(), ';', 'Failed at assert 1');
690690

691-
/** @type {import('@theia/monaco-editor-core/src/vs/editor/contrib/codeAction/browser/codeActionCommands').CodeActionController} */
691+
/** @type {import('@theia/monaco-editor-core/src/vs/editor/contrib/codeAction/browser/codeActionController').CodeActionController} */
692692
const codeActionController = editor.getControl().getContribution('editor.contrib.codeActionController');
693693
const lightBulbNode = () => {
694-
const ui = codeActionController['_ui'].rawValue;
695-
const lightBulb = ui && ui['_lightBulbWidget'].rawValue;
694+
const lightBulb = codeActionController['_lightBulbWidget'].rawValue;
696695
return lightBulb && lightBulb['_domNode'];
697696
};
698697
const lightBulbVisible = () => {
@@ -704,14 +703,14 @@ SPAN {
704703
await waitForAnimation(() => lightBulbVisible());
705704

706705
await commands.executeCommand('editor.action.quickFix');
707-
const codeActionSelector = '.codeActionWidget';
706+
const codeActionSelector = '.action-widget';
708707
assert.isFalse(!!document.querySelector(codeActionSelector), 'Failed at assert 3 - codeActionWidget should not be visible');
709708

710709
console.log('Waiting for Quick Fix widget to be visible');
711710
await waitForAnimation(() => {
712711
const quickFixWidgetVisible = !!document.querySelector(codeActionSelector);
713712
if (!quickFixWidgetVisible) {
714-
console.log('...');
713+
// console.log('...');
715714
return false;
716715
}
717716
return true;
@@ -797,10 +796,10 @@ SPAN {
797796

798797
it('Can execute code actions', async function () {
799798
const editor = await openEditor(demoFileUri);
800-
/** @type {import('@theia/monaco-editor-core/src/vs/editor/contrib/codeAction/browser/codeActionCommands').CodeActionController} */
799+
/** @type {import('@theia/monaco-editor-core/src/vs/editor/contrib/codeAction/browser/codeActionController').CodeActionController} */
801800
const codeActionController = editor.getControl().getContribution('editor.contrib.codeActionController');
802801
const isActionAvailable = () => {
803-
const lightbulbVisibility = codeActionController['_ui'].rawValue?.['_lightBulbWidget'].rawValue?.['_domNode'].style.visibility;
802+
const lightbulbVisibility = codeActionController['_lightBulbWidget'].rawValue?.['_domNode'].style.visibility;
804803
return lightbulbVisibility !== undefined && lightbulbVisibility !== 'hidden';
805804
}
806805
assert.isFalse(isActionAvailable());
@@ -811,7 +810,7 @@ SPAN {
811810
assert.isTrue(isActionAvailable());
812811

813812
await commands.executeCommand('editor.action.quickFix');
814-
await waitForAnimation(() => Boolean(document.querySelector('.context-view-pointerBlock')), 5000, 'No context menu appeared. (1)');
813+
await waitForAnimation(() => Boolean(document.querySelector('.action-widget')), 5000, 'No context menu appeared. (1)');
815814
await animationFrame();
816815

817816
keybindings.dispatchKeyDown('Enter');

0 commit comments

Comments
 (0)