You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// Here we need to attach a `mousedown` listener to the `TabBar`s, `DockPanel`s and the `SidePanel`s. Otherwise, Phosphor handles the event and stops the propagation.
47
+
// Here we need to attach a `mousedown` listener to the `TabBar`s, `DockPanel`s and the `SidePanel`s. Otherwise, Lumino handles the event and stops the propagation.
48
48
// Track the `mousedown` on the `TabBar` for the currently active widget.
Copy file name to clipboardExpand all lines: packages/mini-browser/src/browser/mini-browser-open-handler.ts
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -75,10 +75,10 @@ export class MiniBrowserOpenHandler extends NavigatableWidgetOpenHandler<MiniBro
75
75
/**
76
76
* Instead of going to the backend with each file URI to ask whether it can handle the current file or not,
77
77
* we have this map of extension and priority pairs that we populate at application startup.
78
-
* The real advantage of this approach is the following: [Phosphor cannot run async code when invoking `isEnabled`/`isVisible`
78
+
* The real advantage of this approach is the following: [Lumino cannot run async code when invoking `isEnabled`/`isVisible`
79
79
* for the command handlers](https://github.com/eclipse-theia/theia/issues/1958#issuecomment-392829371)
80
80
* so the menu item would be always visible for the user even if the file type cannot be handled eventually.
81
-
* Hopefully, we could get rid of this hack once we have migrated the existing Phosphor code to [React](https://github.com/eclipse-theia/theia/issues/1915).
81
+
* Hopefully, we could get rid of this hack once we have migrated the existing Lumino code to [React](https://github.com/eclipse-theia/theia/issues/1915).
0 commit comments