core: fix menuBarVisibility

The commit fixes an issue with the `window.menuBarVisibility` preference
where the menu is not set correctly on startup since we wait for the
preference-change event. The fix sets the menu when the preferences are
ready, and updates on preference changes.

Signed-off-by: vince-fugnitto <[email protected]>

Author: vince-fugnitto

packages/core/src/browser/menu/browser-menu-plugin.ts

@@ -58,6 +58,9 @@ export class BrowserMainMenuFactory implements MenuWidgetFactory {
     createMenuBar(): MenuBarWidget {
         const menuBar = new DynamicMenuBarWidget();
         menuBar.id = 'theia:menubar';
+        this.corePreferences.ready.then(() => {
+            this.showMenuBar(menuBar, this.corePreferences.get('window.menuBarVisibility', 'classic'));
+        });
         const preferenceListener = this.corePreferences.onPreferenceChanged(preference => {
             if (preference.preferenceName === 'window.menuBarVisibility') {
                 this.showMenuBar(menuBar, preference.newValue);