core: respect visible menu for fullscreen

The commit updates the handling of `toggle full screen` to respect
`menuBarVisibility` properly. If the `menuBarVisibility` is set to
`visible` the menu should be visible when the app is in fullscreen.

Signed-off-by: vince-fugnitto <[email protected]>

Author: vince-fugnitto

packages/core/src/electron-browser/menu/electron-menu-contribution.ts

@@ -309,7 +309,7 @@ export class ElectronMenuContribution extends BrowserMenuBarContribution impleme
         registry.registerCommand(ElectronCommands.TOGGLE_FULL_SCREEN, {
             isEnabled: () => currentWindow.isFullScreenable(),
             isVisible: () => currentWindow.isFullScreenable(),
-            execute: () => currentWindow.setFullScreen(!currentWindow.isFullScreen())
+            execute: () => this.toggleFullScreen(currentWindow)
         });
     }
 
@@ -377,4 +377,13 @@ export class ElectronMenuContribution extends BrowserMenuBarContribution impleme
             order: '0'
         });
     }
+
+    protected toggleFullScreen(currentWindow: electron.BrowserWindow): void {
+        currentWindow.setFullScreen(!currentWindow.isFullScreen());
+        if (currentWindow.isFullScreen()) {
+            currentWindow.menuBarVisible = this.preferenceService.get('window.menuBarVisibility') === 'visible';
+        } else {
+            currentWindow.menuBarVisible = true;
+        }
+    }
 }