Fixes #350 - java.lang.AssertionError: Attempt to push null on operand stack!

Similar to other fixes for related problems - make sure we record
that a variable is in use so the code generation isnt surprised by
a load instruction for one of them.

Author: aclement

org.aspectj.ajdt.core/src/main/java/org/aspectj/ajdt/internal/compiler/ast/InterTypeFieldDeclaration.java

@@ -412,10 +412,29 @@ private void generateInterfaceReadBody(MethodBinding binding, MethodBinding read
 		codeStream.invoke(Opcodes.OPC_invokeinterface,readMethod,null);
 	}
 
+	/**
+	 * Example:
+	 * 
+	 * For this ITD field on an interface type:
+	 * <pre>
+	 * {@code Set<String> I.changeListeners = new HashSet<String>(); }
+	 * </pre>
+	 * the binding (method we are currently writing) is:
+	 * <pre>
+	 * {@code public static void ajc$interFieldSetDispatch$Azpect$I$changeListeners(I, Set<java.lang.String>)}
+	 * </pre>
+	 * and the writeMethod to be invoked is:
+	 * <pre>
+	 * public abstract void ajc$interFieldSet$Azpect$I$changeListeners(Set<java.lang.String>) 
+	 * </pre>
+	 * 
+	 */
 	private void generateInterfaceWriteBody(MethodBinding binding, MethodBinding writeMethod, CodeStream codeStream) {
 		codeStream.aload_0();
+		LocalVariableBinding valueVar = createUsedVar(codeStream, "value", writeMethod.parameters[0], 1);
 		codeStream.load(writeMethod.parameters[0], 1);
 		codeStream.invoke(Opcodes.OPC_invokeinterface, writeMethod, null);
+		valueVar.recordInitializationEndPC(codeStream.position);
 	}
 
 	private void generateClassReadBody(MethodBinding binding, FieldBinding field, CodeStream codeStream) {

tests/bugs1925/350/Azpect.java

@@ -0,0 +1,8 @@
+import java.util.HashSet;
+import java.util.Set;
+
+interface I {}
+
+public aspect Azpect {
+    private Set<String> I.changeListeners = new HashSet<String>();
+}

tests/src/test/java/org/aspectj/systemtest/ajc1925/Bugs1925Tests.java

@@ -26,6 +26,10 @@ public void testGh336_ProceedCodeGenProblem() {
   public void testGh337_ProceedCodeGenProblem() {
 	  runTest("proceed code gen problem 2");
   }
+  
+  public void testGh350_ITDCodeGenProblem() {
+	  runTest("itd code gen problem");
+  }
 
   @Override
   protected java.net.URL getSpecFile() {

tests/src/test/resources/org/aspectj/systemtest/ajc1925/ajc1925.xml

@@ -104,5 +104,9 @@ JDK 25 (https://openjdk.org/projects/jdk/25/):
 		<compile files="X.aj" options="-17"/>
 		<run class="X"/>
 	</ajc-test>
+	
+	<ajc-test dir="bugs1925/350" vm="24" title="itd code gen problem">
+		<compile files="Azpect.java" options="-25"/>
+	</ajc-test>
 
 </suite>