Upgrading to Java25

Nothing too complicated here. AnnotationResolved was moved in JDT from TagBits
to ExtendedTagBits but that was an easy change to include.  Migrated some tests
from 1924tests to 1925tests because strictly speaking they were fixes after 1.9.24
were released but there was no 1.9.24.1 to include them. Slightly tweaked the
test launcher code because compact source files allow non public static main methods
(added some basic tests for that and the weaving of such types).  Add some
weaving tests for the less strict constructor format too (super() calls don't
have to be first in the constructor now).

Author: aclement

.github/workflows/maven.yml

@@ -24,7 +24,7 @@ jobs:
       matrix:
         # AspectJ_JDK_Update: Always keep LTS versions + latest version supported by JDT Core
         # Check for available Temurin releases on https://adoptium.net/releases.html
-        java: [ 17, 21, 22, 23 ]
+        java: [ 17, 21, 25 ]
 
     runs-on: ubuntu-latest
 

docs/devguide/ajc.adoc

@@ -178,11 +178,11 @@ Limitations which apply to both LTW and CTW modes include:
   <Directory> defaults to the current working dir.
 
 // AspectJ_JDK_Update: increment max. version and, if necessary, min. version
-`-source <[1.3 to 22]>`::
+`-source <[1.8 to 25]>`::
   Set source file Java language level
-`-target <[1.3 to 22]>`::
+`-target <[1.8 to 25]>`::
   Set classfile Java bytecode level
-`-<[1.3 to 22]>`::
+`-<[1.8 to 25]>`::
   Set compiler compliance level. Implies identical `-source` and `-target` levels.
   E.g., `-11` implies `-source 11` and `-target 11`.
 

docs/index.adoc

@@ -98,6 +98,7 @@ JDK to run
 // AspectJ_JDK_Update: add new release to table
 |Release notes |Release notes, describing new features, improvements, bugfixes per AspectJ version: +
  +
+xref:release/README-1.9.25.adoc[1.9.25],
 xref:release/README-1.9.24.adoc[1.9.24],
 xref:release/README-1.9.23.adoc[1.9.23],
 xref:release/README-1.9.22.adoc[1.9.22 / 1.9.22.1],

docs/release/JavaVersionCompatibility.adoc

@@ -9,6 +9,7 @@ be easily concluded from the AspectJ version number anymore, and we are sorry fo
 [%autowidth, stripes=even, options="header"]
 |===
 |AspectJ version |Java version |Comments
+|1.9.25 |25 |
 |1.9.24 |24 |
 |1.9.23 |23 |
 |1.9.22 - 1.9.22.1 |22 |

docs/release/README-1.9.24.adoc

@@ -4,9 +4,6 @@
 
 = AspectJ 1.9.24
 
-// AspectJ_JDK_Update: Each a.b.c release needs a new release notes document. For a.b.c.d minors, the existing a.b.c
-// document can be updated. After copying this document, remove the comment from the previous one.
-
 _© Copyright 2025 Contributors. All rights reserved._
 
 _Release info: 1.9.24 available 28-Mar-2025_

docs/release/README-1.9.25.adoc

@@ -0,0 +1,87 @@
+= AspectJ 1.9.25
+:doctype: book
+:leveloffset: +1
+
+= AspectJ 1.9.25
+
+// AspectJ_JDK_Update: Each a.b.c release needs a new release notes document. For a.b.c.d minors, the existing a.b.c
+// document can be updated. After copying this document, remove the comment from the previous one.
+
+_© Copyright 2025 Contributors. All rights reserved._
+
+_Release info: 1.9.25 available 27-Oct-2025_
+
+Please note that Bugzilla for issue management is deprecated and new issues should be filed as
+https://github.com/eclipse-aspectj/aspectj/issues/new[GitHub issues]. The list of issues addressed for 1.9.25 can be
+found here:
+
+* https://github.com/eclipse-aspectj/aspectj/issues?q=is%3Aissue+is%3Aclosed++milestone%3A1.9.25[GitHub 1.9.25]
+* https://bugs.eclipse.org/bugs/buglist.cgi?bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&f0=OP&f1=OP&f3=CP&f4=CP&j1=OR&list_id=16866879&product=AspectJ&query_format=advanced&target_milestone=1.9.25[Bugzilla 1.9.25]
+
+== New features
+
+AspectJ 1.9.25 supports https://openjdk.java.net/projects/jdk/25/[Java 25], its final and preview features:
+
+* 470:	PEM Encodings of Cryptographic Objects (Preview)
+* 502:	Stable Values (Preview)
+* 503:	Remove the 32-bit x86 Port
+* 505:	Structured Concurrency (Fifth Preview)
+* 506:	Scoped Values
+* 507:	Primitive Types in Patterns, instanceof, and switch (Third Preview)
+* 508:	Vector API (Tenth Incubator)
+* 509:	JFR CPU-Time Profiling (Experimental)
+* 510:	Key Derivation Function API
+* 511:	Module Import Declarations
+* 512:	Compact Source Files and Instance Main Methods
+* 513:	Flexible Constructor Bodies
+* 514:	Ahead-of-Time Command-Line Ergonomics
+* 515:	Ahead-of-Time Method Profiling
+* 518:	JFR Cooperative Sampling
+* 519:	Compact Object Headers
+* 520:	JFR Method Timing & Tracing
+* 521:	Generational Shenandoah
+
+Some of these are API/JVM only so don't affect the compiler and should just work on Java 25 runtimes.
+
+== Improvements
+
+* No major improvements
+
+== Other changes and bug fixes
+
+Importantly with the adoption of JDT Compiler later than 22, the versions of Java 1.1 > 1.7 are considered no longer
+supported so any attempt to specify a build for any of those Java versions will now fail immediately.
+
+== AspectJ usage hints
+
+[[ajc_build_system_requirements]]
+=== AspectJ compiler build system requirements
+
+Since 1.9.21, the AspectJ compiler `ajc` (contained in the `aspectjtools` library) no longer works on JDKs 11 to 16. The
+minimum compile-time requirement is now JDK 17 due to upstream changes in the Eclipse Java Compiler (subset of JDT
+Core), which AspectJ is a fork of. You can still compile to legacy target versions as low as Java 1.3 when compiling
+plain Java code or using plain Java ITD constructs which do not require the AspectJ runtime `aspectjrt`, but the
+compiler itself needs JDK 17+. Just like in previous AspectJ versions, both the runtime `aspectjrt` and the load-time
+weaver `aspectjweaver` still only require JRE 8+.
+
+History: Since 1.9.8, the AspectJ compiler ajc needed JDK 11+, before then JDK 8+.
+
+[[ltw_java_16]]
+=== Use LTW on Java 16+
+
+**Since AspectJ 1.9.21.1, using `--add-opens` is no longer necessary!** The additional JVM command-line option was
+necessary for LTW on JRE 16+ in all AspectJ versions up to 1.9.21. Since AspectJ 1.9.21.1, the LTW agent uses an
+alternative approach for defining new classes during weaving, which works without `--add-opens` - at least for now, i.e.
+JDKs 8 to 22. There still is no canonical solution, because link:https://bugs.openjdk.org/browse/JDK-8200559[JDK-8200559]
+is still unresolved since 2018.
+
+[[compile_with_preview]]
+=== Compile with Java preview features
+
+For features marked as preview on a given JDK, you need to compile with `ajc --enable-preview` and run with
+`java --enable-preview` on that JDK.
+
+Please note, that you cannot run code compiled with preview features on any other JDK than the one used for compilation.
+For example, records compiled with preview on JDK 15 cannot be used on JDK 16 without recompilation. This is a JVM
+limitation unrelated to AspectJ. Also, e.g. sealed classes are preview-1 on JDK 15 and preview-2 on JDK 16. You still
+need to recompile, no matter what.