Skip to content

Commit 9dd05c1

Browse files
author
Benedict Bleimschein
committed
Address PR review feedback
- Fix issues identified in code review - Update documentation and rule files based on feedback
1 parent cf79899 commit 9dd05c1

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

dynatrace-agent-rules/rules/DynatraceSpanAnalysis.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ fetch spans, from:now() - 4h // Adjust based on problem timeframe
335335
```dql
336336
// Correlate span trace IDs with log entries
337337
fetch logs, from:now() - 4h
338-
| filter trace_id == "162aaed047f724043441c38744bcf37d" // From span analysis
338+
| filter trace.id == "162aaed047f724043441c38744bcf37d" // From span analysis
339339
| fields timestamp, content, exception.message, k8s.pod.name
340340
| sort timestamp desc
341341
```
@@ -449,7 +449,7 @@ fetch events, from:now() - 24h
449449

450450
```dql
451451
// Service filtering by entity ID (most reliable)
452-
| filter dt.entity.service == "SERVICE-BECA49FB15C72B6A"
452+
| filter dt.entity.service == "SERVICE-PLACEHOLDER"
453453
454454
// Service filtering by name (may not always work)
455455
| filter service.name == "payment" // Sometimes works

dynatrace-agent-rules/rules/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ This directory contains comprehensive workflow rules for AI-assisted Dynatrace a
77
### 1. Install Dynatrace MCP Server
88

99
```bash
10-
npm install -g @dynatrace/mcp-server
10+
npm install -g @dynatrace-oss/dynatrace-mcp-server
1111
# Configure with your Dynatrace environment credentials
1212
```
1313

dynatrace-agent-rules/rules/observabilityProblems.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ fetch events, from:now() - 24h
327327
| sort timestamp desc
328328
```
329329

330-
| limit 10
330+
331331

332332
````
333333

0 commit comments

Comments
 (0)