REFACTOR: Remove getType() override to allow extensibility

jsirish · jsirish · commit d89aecaefc75 · 2025-12-02T00:24:41.000-06:00
Remove the getType() method override so the element inherits BaseElement::getType() which uses i18n_singular_name(). This allows sites to customize the element's display name via extensions by setting $singular_name. Fixes #13
diff --git a/src/Elements/ElementCarousel.php b/src/Elements/ElementCarousel.php
@@ -110,12 +110,4 @@ protected function provideBlockSchema()
         $blockSchema['content'] = $this->getSummary();
         return $blockSchema;
     }
-
-    /**
-     * @return string
-     */
-    public function getType()
-    {
-        return _t(__CLASS__ . '.BlockType', 'Carousel');
-    }
 }

Original file line number	Diff line number	Diff line change
`@@ -110,12 +110,4 @@ protected function provideBlockSchema()`
`110`	`110`	`$blockSchema['content'] = $this->getSummary();`
`111`	`111`	`return $blockSchema;`
`112`	`112`	`}`
`113`		`-`
`114`		`- /**`
`115`		`- * @return string`
`116`		`- */`
`117`		`- public function getType()`
`118`		`- {`
`119`		`- return _t(__CLASS__ . '.BlockType', 'Carousel');`
`120`		`- }`
`121`	`113`	`}`