feat: send half of this (idk if it even works tbh)

Author: dy-tea

examples/README.md

@@ -615,6 +615,23 @@ doorsctl send next                      # Send focused window to next desktop
 doorsctl send prev|previous             # Send focused window to previous desktop
 ```
 
+### Global Shortcuts (Portal)
+
+Doors implements the XDG Desktop Portal `GlobalShortcuts` interface on
+`org.freedesktop.impl.portal.desktop.doors`. Applications can register global
+shortcuts via the portal, and Doors notifies them when the bound key is pressed.
+
+```
+super + F1
+  global-shortcut com.appname.app action-name
+```
+
+```
+doorsctl globalshortcuts
+```
+
+List all currently registered global shortcuts across all portal sessions. If none are registered, prints `none`.
+
 #### Other Commands
 
 ```

include/config.h

@@ -88,6 +88,7 @@ typedef enum {
 	BIND_INTERACTIVE_RESIZE,
 	BIND_TILING_DRAG,
 	BIND_EXTERNAL,
+	BIND_GLOBAL_SHORTCUT,
 } bind_action_t;
 
 typedef enum {

include/global_shortcuts.h

@@ -58,3 +58,5 @@ void global_shortcuts_init(void);
 void global_shortcuts_fini(void);
 bool global_shortcuts_handle_key(uint32_t modifiers, uint32_t keycode, const xkb_keysym_t *syms,
 	int nsyms, uint32_t state, uint32_t time_msec);
+void global_shortcuts_send_by_app(const char *app_id, const char *shortcut_id, bool pressed);
+void global_shortcuts_list(char *buf, size_t buf_size);

include/ipc_cmd.h

@@ -26,5 +26,6 @@ void ipc_cmd_scroller(char **args, int num, int client_fd);
 void ipc_cmd_master_stack(char **args, int num, int client_fd);
 void ipc_cmd_hotkey(char **args, int num, int client_fd);
 void ipc_cmd_scratchpad(char **args, int num, int client_fd);
+void ipc_cmd_globalshortcuts(char **args, int num, int client_fd);
 void ipc_cmd_bezier(char **args, int num, int client_fd);
 void ipc_cmd_spring(char **args, int num, int client_fd);

meson.build

@@ -109,6 +109,7 @@ executable(
 		'src' / 'ipc_cmd' / 'actions.c',
 		'src' / 'ipc_cmd' / 'config.c',
 		'src' / 'ipc_cmd' / 'env.c',
+		'src' / 'ipc_cmd' / 'globalshortcuts.c',
 		'src' / 'ipc_cmd' / 'desktop.c',
 		'src' / 'ipc_cmd' / 'dispatch.c',
 		'src' / 'ipc_cmd' / 'hotkey.c',

src/config.c

@@ -1,4 +1,5 @@
 #include "config.h"
+#include "global_shortcuts.h"
 #include "keyboard.h"
 #include "master_stack.h"
 #include "server.h"
@@ -235,6 +236,9 @@ bind_action_t parse_action(const char *cmd, int *desktop_index, char *submap_nam
 		return BIND_ENTER_SUBMAP;
 	}
 
+	if (strncmp(cmd, "global-shortcut ", 16) == 0)
+		return BIND_GLOBAL_SHORTCUT;
+
 	if (strncmp(cmd, "doorsctl ", 9) != 0)
 		return BIND_EXTERNAL;
 
@@ -698,7 +702,7 @@ static void parse_hotkey_line(const char *hotkey_str, const char *command_str) {
 			bind_action_t action = parse_action(single_cmd, &desktop_index, submap_name);
 			wlr_log(WLR_DEBUG, "Parsed action: %d for cmd: '%s' submap: '%s'", action, single_cmd,
 				submap_name);
-			if (action != BIND_EXTERNAL)
+			if (action != BIND_EXTERNAL && action != BIND_GLOBAL_SHORTCUT)
 				add_keybind(modifiers, keysym, keycode, use_keycode, action, desktop_index, NULL,
 					submap_name[0] ? submap_name : NULL);
 			else
@@ -1253,6 +1257,22 @@ void execute_bind(bind_t b) {
 	case BIND_INTERACTIVE_RESIZE:
 	case BIND_TILING_DRAG:
 		break;
+	case BIND_GLOBAL_SHORTCUT:
+		if (b.external_cmd[0] != '\0') {
+			char app_id[256], shortcut_id[256];
+			const char *args = b.external_cmd + 16;
+			const char *space = strchr(args, ' ');
+			if (space) {
+				size_t app_len = (size_t)(space - args);
+				if (app_len >= sizeof(app_id))
+					app_len = sizeof(app_id) - 1;
+				memcpy(app_id, args, app_len);
+				app_id[app_len] = '\0';
+				snprintf(shortcut_id, sizeof(shortcut_id), "%s", space + 1);
+				global_shortcuts_send_by_app(app_id, shortcut_id, true);
+			}
+		}
+		break;
 	}
 }
 
@@ -1466,7 +1486,8 @@ const char *bind_action_name(bind_action_t action) {
 		"interactive_move",
 		"interactive_resize",
 		"tiling_drag",
-		"external"
+		"external",
+		"portal_shortcut"
 	};
 	if (action >= 0 && action < (int)(sizeof(names) / sizeof(names[0])))
 		return names[action];

src/global_shortcuts.c

@@ -6,6 +6,7 @@
 #include <string.h>
 #include <strings.h>
 #include <systemd/sd-bus.h>
+#include <time.h>
 #include <wayland-server-core.h>
 #include <wlr/types/wlr_keyboard.h>
 #include <wlr/util/log.h>
@@ -604,8 +605,7 @@ void global_shortcuts_init(void) {
 
 	r = sd_bus_request_name(gs.bus, GS_BUS_NAME, 0);
 	if (r < 0) {
-		wlr_log(WLR_ERROR, "failed to request bus name '%s': %s", GS_BUS_NAME,
-			strerror(-r));
+		wlr_log(WLR_ERROR, "failed to request bus name '%s': %s", GS_BUS_NAME, strerror(-r));
 		sd_bus_unref(gs.bus);
 		gs.bus = NULL;
 		return;
@@ -708,6 +708,65 @@ bool global_shortcuts_handle_key(uint32_t modifiers, uint32_t keycode, const xkb
 	return false;
 }
 
+void global_shortcuts_send_by_app(const char *app_id, const char *shortcut_id, bool pressed) {
+	if (!gs.initialized || !gs.bus || !app_id || !shortcut_id)
+		return;
+
+	struct timespec tp;
+	clock_gettime(CLOCK_MONOTONIC, &tp);
+	uint64_t timestamp = (uint64_t)tp.tv_sec * 1000 + (uint64_t)tp.tv_nsec / 1000000;
+
+	gs_session_t *sess;
+	wl_list_for_each(sess, &gs.sessions, link) {
+		if (sess->destroyed)
+			continue;
+		if (strcmp(sess->app_id, app_id) != 0)
+			continue;
+		gs_shortcut_t *sc;
+		wl_list_for_each(sc, &sess->shortcuts, link) {
+			if (strcmp(sc->id, shortcut_id) == 0) {
+				if (pressed)
+					emit_activated(sess, sc, timestamp);
+				else
+					emit_deactivated(sess, sc, timestamp);
+				return;
+			}
+		}
+	}
+}
+
+void global_shortcuts_list(char *buf, size_t buf_size) {
+	if (!buf || buf_size == 0)
+		return;
+
+	int offset = 0;
+
+	if (!gs.initialized || !gs.bus) {
+		snprintf(buf, buf_size, "not initialized\n");
+		return;
+	}
+
+	gs_session_t *sess;
+	wl_list_for_each(sess, &gs.sessions, link) {
+		if (sess->destroyed)
+			continue;
+		gs_shortcut_t *sc;
+		wl_list_for_each(sc, &sess->shortcuts, link) {
+			int ret = snprintf(buf + offset, buf_size - offset, "%s:%s\t%s\n",
+				sess->app_id ? sess->app_id : "?", sc->id ? sc->id : "?",
+				sc->description ? sc->description : "");
+			if (ret < 0)
+				return;
+			if ((size_t)ret >= buf_size - offset)
+				return;
+			offset += ret;
+		}
+	}
+
+	if (offset == 0)
+		snprintf(buf, buf_size, "none\n");
+}
+
 
 #else // !HAVE_SYSTEMD
 
@@ -733,5 +792,16 @@ bool global_shortcuts_handle_key(uint32_t modifiers, uint32_t keycode, const xkb
 	return false;
 }
 
+void global_shortcuts_send_by_app(const char *app_id, const char *shortcut_id, bool pressed) {
+	(void)app_id;
+	(void)shortcut_id;
+	(void)pressed;
+}
+
+void global_shortcuts_list(char *buf, size_t buf_size) {
+	if (buf && buf_size)
+		snprintf(buf, buf_size, "not available (no systemd)\n");
+}
+
 
 #endif // HAVE_SYSTEMD

src/ipc_cmd/dispatch.c

@@ -22,6 +22,7 @@ static const cmd_entry_t cmds[] = {
 	{"equalize", ipc_cmd_equalize},
 	{"flip", ipc_cmd_flip},
 	{"focus", ipc_cmd_focus},
+	{"globalshortcuts", ipc_cmd_globalshortcuts},
 	{"hotkey", ipc_cmd_hotkey},
 	{"input", ipc_cmd_input},
 	{"keyboard_grouping", ipc_cmd_keyboard_grouping},

src/ipc_cmd/globalshortcuts.c

@@ -0,0 +1,11 @@
+#include "global_shortcuts.h"
+#include "ipc.h"
+#include "ipc_cmd.h"
+
+void ipc_cmd_globalshortcuts(char **args, int num, int client_fd) {
+	(void)args;
+	(void)num;
+	char buf[DOORS_BUFSIZ];
+	global_shortcuts_list(buf, sizeof(buf));
+	send_success(client_fd, buf);
+}

src/ipc_cmd/hotkey.c

@@ -108,7 +108,8 @@ void ipc_cmd_hotkey(char **args, int num, int client_fd) {
 	bind_action_t action = parse_action(cmd, &desktop_index, submap_name);
 
 	add_keybind(modifiers, keysym, keycode, use_keycode, action, desktop_index,
-		action == BIND_EXTERNAL ? cmd : NULL, submap_name[0] ? submap_name : NULL);
+		(action == BIND_EXTERNAL || action == BIND_GLOBAL_SHORTCUT) ? cmd : NULL,
+		submap_name[0] ? submap_name : NULL);
 
 	send_success(client_fd, "hotkey added\n");
 }