Skip to content

Commit 08dfbed

Browse files
Add slotscheck (#1233)
* add slotscheck * remove obsolete slots test * add changelog entry * fix slotscheck command in GH workflow
1 parent af08071 commit 08dfbed

File tree

6 files changed

+118
-118
lines changed

6 files changed

+118
-118
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ jobs:
5151
- name: Run tests
5252
run: |
5353
poetry run flake8 .
54-
# In order to make `exclude` option works we need to separate the checks
55-
# of returns and its tests in a two separated commands
54+
# In order to make `exclude` option work, we need to separate the checks
55+
# of returns and its tests into two separated commands
5656
poetry run mypy returns
5757
poetry run mypy tests
5858
# Different python versions are covered differently:
@@ -62,6 +62,7 @@ jobs:
6262
poetry run poetry check
6363
poetry run pip check
6464
poetry run safety check --full-report
65+
poetry run slotscheck returns --verbose
6566
# We do this to speed up the build:
6667
poetry run pytest typesafety -p no:cov -o addopts="" --mypy-ini-file=setup.cfg
6768

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@ See [0Ver](https://0ver.org/).
1111

1212
- Adds `attempt` decorator
1313

14+
### Misc
15+
16+
- Check ``__slots__`` correctness with `slotscheck`
17+
18+
1419
## 0.18.0
1520

1621
New Year Release! 🎄

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ Before submitting your code please do the following steps:
118118
7. Run `mypy` to ensure that types are correct
119119
8. Run `flake8` to ensure that style is correct
120120
9. Run `doc8` to ensure that docs are correct
121+
10. Run `slotscheck` to ensure that slots are correct
121122

122123

123124
## Other help

0 commit comments

Comments
 (0)