Use artifact registry instead of daemon registry (#8)

Author: rutvijmehta-harness

app.go

@@ -102,6 +102,12 @@ func Run() {
 			Usage:  "don't start the docker daemon",
 			EnvVar: "PLUGIN_DAEMON_OFF",
 		},
+		cli.StringFlag{
+			Name:   "artifact.registry",
+			Usage:  "artifact registry",
+			Value:  "https://index.docker.io/v1/",
+			EnvVar: "ARTIFACT_REGISTRY,PLUGIN_REGISTRY,DOCKER_REGISTRY",
+		},
 		cli.StringFlag{
 			Name:   "dockerfile",
 			Usage:  "build dockerfile",
@@ -372,19 +378,20 @@ func run(c *cli.Context) error {
 			BuildxLoad:  c.Bool("buildx-load"),
 		},
 		Daemon: Daemon{
-			Registry:      c.String("docker.registry"),
-			Mirror:        c.String("daemon.mirror"),
-			StorageDriver: c.String("daemon.storage-driver"),
-			StoragePath:   c.String("daemon.storage-path"),
-			Insecure:      c.Bool("daemon.insecure"),
-			Disabled:      c.Bool("daemon.off"),
-			IPv6:          c.Bool("daemon.ipv6"),
-			Debug:         c.Bool("daemon.debug"),
-			Bip:           c.String("daemon.bip"),
-			DNS:           c.StringSlice("daemon.dns"),
-			DNSSearch:     c.StringSlice("daemon.dns-search"),
-			MTU:           c.String("daemon.mtu"),
-			RegistryType:  registryType,
+			Registry:         c.String("docker.registry"),
+			Mirror:           c.String("daemon.mirror"),
+			StorageDriver:    c.String("daemon.storage-driver"),
+			StoragePath:      c.String("daemon.storage-path"),
+			Insecure:         c.Bool("daemon.insecure"),
+			Disabled:         c.Bool("daemon.off"),
+			IPv6:             c.Bool("daemon.ipv6"),
+			Debug:            c.Bool("daemon.debug"),
+			Bip:              c.String("daemon.bip"),
+			DNS:              c.StringSlice("daemon.dns"),
+			DNSSearch:        c.StringSlice("daemon.dns-search"),
+			MTU:              c.String("daemon.mtu"),
+			RegistryType:     registryType,
+			ArtifactRegistry: c.String("artifact.registry"),
 		},
 		Builder: Builder{
 			Name:       c.String("builder-name"),

docker.go

@@ -15,19 +15,20 @@ import (
 type (
 	// Daemon defines Docker daemon parameters.
 	Daemon struct {
-		Registry      string             // Docker registry
-		Mirror        string             // Docker registry mirror
-		Insecure      bool               // Docker daemon enable insecure registries
-		StorageDriver string             // Docker daemon storage driver
-		StoragePath   string             // Docker daemon storage path
-		Disabled      bool               // DOcker daemon is disabled (already running)
-		Debug         bool               // Docker daemon started in debug mode
-		Bip           string             // Docker daemon network bridge IP address
-		DNS           []string           // Docker daemon dns server
-		DNSSearch     []string           // Docker daemon dns search domain
-		MTU           string             // Docker daemon mtu setting
-		IPv6          bool               // Docker daemon IPv6 networking
-		RegistryType  drone.RegistryType // Docker registry type
+		Registry         string             // Docker registry
+		Mirror           string             // Docker registry mirror
+		Insecure         bool               // Docker daemon enable insecure registries
+		StorageDriver    string             // Docker daemon storage driver
+		StoragePath      string             // Docker daemon storage path
+		Disabled         bool               // DOcker daemon is disabled (already running)
+		Debug            bool               // Docker daemon started in debug mode
+		Bip              string             // Docker daemon network bridge IP address
+		DNS              []string           // Docker daemon dns server
+		DNSSearch        []string           // Docker daemon dns search domain
+		MTU              string             // Docker daemon mtu setting
+		IPv6             bool               // Docker daemon IPv6 networking
+		RegistryType     drone.RegistryType // Docker registry type
+		ArtifactRegistry string             // Docker registry where artifact can be viewed
 	}
 
 	Builder struct {
@@ -237,8 +238,10 @@ func (p Plugin) Exec() error {
 
 	// write to artifact file
 	if p.ArtifactFile != "" {
+		// ArtifactRegistry here will be read from env variable ARTIFACT_REGISTRY (valid for ACR). If this env
+		// variable is not present, it'll be read from PLUGIN_REGISTRY which is valid for docker / ecr / gcr.
 		if digest, err := getDigest(p.MetadataFile); err == nil {
-			if err = drone.WritePluginArtifactFile(p.Daemon.RegistryType, p.ArtifactFile, p.Daemon.Registry, p.Build.Repo, digest, p.Build.Tags); err != nil {
+			if err = drone.WritePluginArtifactFile(p.Daemon.RegistryType, p.ArtifactFile, p.Daemon.ArtifactRegistry, p.Build.Repo, digest, p.Build.Tags); err != nil {
 				fmt.Printf("Failed to write plugin artifact file at path: %s with error: %s\n", p.ArtifactFile, err)
 			}
 		} else {