Merge pull request #35 from Aishwarya-Lad/CI-13924

Ompragash · web-flow · commit 387a8e442f27 · 2024-08-21T21:11:27.000+05:30
fix:[CI-13924]: print validation instead of raising error
diff --git a/docker.go b/docker.go
@@ -180,10 +180,10 @@ func (p Plugin) Exec() error {
 	// instead of writing to config file directly, using docker's login func
 	if p.BaseImageRegistry != "" {
 		if p.BaseImageUsername == "" {
-			return fmt.Errorf("Username cannot be empty. The base image connector requires authenticated access. Please either use an authenticated connector, or remove the base image connector.")
+			fmt.Printf("Username cannot be empty. The base image connector requires authenticated access. Please either use an authenticated connector, or remove the base image connector.")
 		}
 		if p.BaseImagePassword == "" {
-			return fmt.Errorf("Password cannot be empty. The base image connector requires authenticated access. Please either use an authenticated connector, or remove the base image connector.")
+			fmt.Printf("Password cannot be empty. The base image connector requires authenticated access. Please either use an authenticated connector, or remove the base image connector.")
 		}
 		var baseConnectorLogin Login
 		baseConnectorLogin.Registry = p.BaseImageRegistry

Original file line number	Diff line number	Diff line change
`@@ -180,10 +180,10 @@ func (p Plugin) Exec() error {`
`180`	`180`	`// instead of writing to config file directly, using docker's login func`
`181`	`181`	`if p.BaseImageRegistry != "" {`
`182`	`182`	`if p.BaseImageUsername == "" {`
`183`		`- return fmt.Errorf("Username cannot be empty. The base image connector requires authenticated access. Please either use an authenticated connector, or remove the base image connector.")`
	`183`	`+ fmt.Printf("Username cannot be empty. The base image connector requires authenticated access. Please either use an authenticated connector, or remove the base image connector.")`
`184`	`184`	`}`
`185`	`185`	`if p.BaseImagePassword == "" {`
`186`		`- return fmt.Errorf("Password cannot be empty. The base image connector requires authenticated access. Please either use an authenticated connector, or remove the base image connector.")`
	`186`	`+ fmt.Printf("Password cannot be empty. The base image connector requires authenticated access. Please either use an authenticated connector, or remove the base image connector.")`
`187`	`187`	`}`
`188`	`188`	`var baseConnectorLogin Login`
`189`	`189`	`baseConnectorLogin.Registry = p.BaseImageRegistry`