Skip to content

Run Publish only when needed #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

Conversation

MiYanni
Copy link
Member

@MiYanni MiYanni commented Jul 10, 2025

Summary

I noticed the nightly build tries to run Publish, but it won't actually do anything. This makes it so Publish only runs when there is actually something that needs to be published.

The PR just adds this one line:

- ${{ if or(eq(parameters.publishToAzDO, true), eq(parameters.publishToNuGet, true)) }}:

But everything has to be indented under it. Nothing was changed in the lines under it. If you compare ignoring whitespace, it is easy to see.

image

@MiYanni MiYanni requested a review from a team July 10, 2025 17:24
Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great idea, looks good with me!

@MiYanni MiYanni merged commit 8f7817c into dotnet:main Jul 10, 2025
2 checks passed
@MiYanni
Copy link
Member Author

MiYanni commented Jul 10, 2025

/backport to release/9.0.1xx

Copy link

@MiYanni
Copy link
Member Author

MiYanni commented Jul 10, 2025

/backport to release/9.0.3xx

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants