[release/6.0] Fix catching of generic exception in crossgened shared generic code (#66207)

* Add regression test for #66005

* Fix

* Update src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs

Co-authored-by: Michal Strehovský <[email protected]>

Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: Michal Strehovský <[email protected]>

Author: 3 people

src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs

@@ -604,7 +604,8 @@ private bool Get_CORINFO_METHOD_INFO(MethodDesc method, MethodIL methodIL, CORIN
             methodInfo->ILCode = (byte*)GetPin(ilCode);
             methodInfo->ILCodeSize = (uint)ilCode.Length;
             methodInfo->maxStack = (uint)methodIL.MaxStack;
-            methodInfo->EHcount = (uint)methodIL.GetExceptionRegions().Length;
+            var exceptionRegions = methodIL.GetExceptionRegions();
+            methodInfo->EHcount = (uint)exceptionRegions.Length;
             methodInfo->options = methodIL.IsInitLocals ? CorInfoOptions.CORINFO_OPT_INIT_LOCALS : (CorInfoOptions)0;
 
             if (method.AcquiresInstMethodTableFromThis())
@@ -623,6 +624,24 @@ private bool Get_CORINFO_METHOD_INFO(MethodDesc method, MethodIL methodIL, CORIN
             Get_CORINFO_SIG_INFO(method, sig: &methodInfo->args);
             Get_CORINFO_SIG_INFO(methodIL.GetLocals(), &methodInfo->locals);
 
+#if READYTORUN
+            if ((methodInfo->options & CorInfoOptions.CORINFO_GENERICS_CTXT_MASK) != 0)
+            {
+                foreach (var region in exceptionRegions)
+                {
+                    if (region.Kind == ILExceptionRegionKind.Catch)
+                    {
+                        TypeDesc catchType = (TypeDesc)methodIL.GetObject(region.ClassToken);
+                        if (catchType.IsCanonicalSubtype(CanonicalFormKind.Any))
+                        {
+                            methodInfo->options |= CorInfoOptions.CORINFO_GENERICS_CTXT_KEEP_ALIVE;
+                            break;
+                        }
+                    }
+                }
+            }
+#endif
+
             return true;
         }
 

src/tests/Regressions/coreclr/GitHub_66005/test66005.cs

@@ -0,0 +1,35 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using System;
+using System.Runtime.CompilerServices;
+
+class Program
+{
+    [MethodImpl(MethodImplOptions.NoInlining)]
+    static void Test<TException>() where TException : Exception
+    {
+        try
+        {
+            throw new InvalidOperationException();
+        }
+        catch (TException)
+        {
+            return;
+        }
+    }
+
+    static int Main()
+    {
+        try
+        {
+            Test<InvalidOperationException>();
+        }
+        catch
+        {
+            return -1;
+        }
+
+        return 100;
+    }
+}

src/tests/Regressions/coreclr/GitHub_66005/test66005.csproj

@@ -0,0 +1,9 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <CLRTestPriority>1</CLRTestPriority>
+  </PropertyGroup>
+  <ItemGroup>
+    <Compile Include="test66005.cs" />
+  </ItemGroup>
+</Project>