Skip to content

Commit 5deefbf

Browse files
Add attribute type name into the message when the definition cannot find (#12010)
1 parent dfa4336 commit 5deefbf

16 files changed

+34
-32
lines changed

src/Tasks.UnitTests/WriteCodeFragment_Tests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1071,7 +1071,7 @@ public void MessageDisplayPositionalParameterNameWhenAttributeNotFound()
10711071
task.OutputDirectory = new TaskItem(Path.GetTempPath());
10721072
bool result = task.Execute();
10731073

1074-
engine.AssertLogContains("Could not infer the type of parameter \"_Parameter1\" because the attribute type is unknown. The value will be treated as a string.");
1074+
engine.AssertLogContains("Could not infer the type of parameter \"_Parameter1\" because the attribute type \"System.TheAttributeCannotFound\" is unknown. The value will be treated as a string.");
10751075
}
10761076

10771077
/// <summary>

src/Tasks/Resources/Strings.resx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2459,7 +2459,7 @@
24592459
<value>Generated by the MSBuild WriteCodeFragment class.</value>
24602460
</data>
24612461
<data name="WriteCodeFragment.CouldNotInferParameterType" xml:space="preserve">
2462-
<value>Could not infer the type of parameter "{0}" because the attribute type is unknown. The value will be treated as a string.</value>
2462+
<value>Could not infer the type of parameter "{0}" because the attribute type "{1}" is unknown. The value will be treated as a string.</value>
24632463
</data>
24642464
<data name="WriteCodeFragment.CouldNotConvertToInferredType" xml:space="preserve">
24652465
<value>Could not convert the value for parameter "{0}" to the inferred type "{1}". The value will be treated as a string. {2}</value>

src/Tasks/Resources/xlf/Strings.cs.xlf

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Resources/xlf/Strings.de.xlf

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Resources/xlf/Strings.es.xlf

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Resources/xlf/Strings.fr.xlf

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Resources/xlf/Strings.it.xlf

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Resources/xlf/Strings.ja.xlf

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Resources/xlf/Strings.ko.xlf

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Tasks/Resources/xlf/Strings.pl.xlf

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)