Skip to content

Commit f9035bc

Browse files
radicalradical
authored
[tests] Re-enable some quarantined tests that haven't been failing (#8615)
* [tests] Re-enable some quarantined tests that haven't been failing Fixes #7930 Fixes #7943 Fixes #8103 Fixes #8192 Fixes #8200 Fixes #8326 Fixes #8400 Fixes #8511 Fixes #8512 Fixes #8513 Fixes #8514 * fix build * Re-enable some tests in Aspire.Hosting.Tests.DistributedApplicationTests All these tests were using the same issue url. And haven't failed recently in github actions. Issue: #4651
1 parent 9d43d6e commit f9035bc

File tree

8 files changed

+1
-31
lines changed

8 files changed

+1
-31
lines changed

‎.github/workflows/run-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ on:
1616
testSessionTimeoutMs:
1717
required: false
1818
type: string
19-
default: "600000"
19+
default: "900000"
2020
testHangTimeout:
2121
required: false
2222
type: string

‎tests/Aspire.Dashboard.Tests/Integration/Playwright/AppBarTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ await AsyncTestHelpers.AssertIsTrueRetryAsync(
6565
}
6666

6767
[Fact]
68-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/7943")]
6968
public async Task AppBar_Change_Theme_ReloadPage()
7069
{
7170
// Arrange

‎tests/Aspire.Hosting.Testing.Tests/TestingBuilderTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,6 @@ public async Task GetHttpClientBeforeStart(bool genericEntryPoint)
210210
[InlineData(false, true)]
211211
[InlineData(true, false)]
212212
[InlineData(true, true)]
213-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/7930")]
214213
public async Task ArgsPropagateToAppHostConfiguration(bool genericEntryPoint, bool directArgs)
215214
{
216215
string[] args = directArgs ? ["APP_HOST_ARG=42"] : [];

‎tests/Aspire.Hosting.Tests/DistributedApplicationTests.cs

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,6 @@ public void TryAddWillNotAddTheSameLifecycleHook()
311311
}
312312

313313
[Fact]
314-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
315314
public async Task AllocatedPortsAssignedAfterHookRuns()
316315
{
317316
using var testProgram = CreateTestProgram("ports-assigned-after-hook-runs");
@@ -344,7 +343,6 @@ public Task AfterEndpointsAllocatedAsync(DistributedApplicationModel appModel, C
344343
}
345344

346345
[Fact]
347-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
348346
public async Task TestServicesWithMultipleReplicas()
349347
{
350348
var replicaCount = 3;
@@ -401,7 +399,6 @@ public async Task TestServicesWithMultipleReplicas()
401399

402400
[Fact]
403401
[RequiresDocker]
404-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
405402
public async Task VerifyContainerArgs()
406403
{
407404
using var testProgram = CreateTestProgram("verify-container-args");
@@ -486,7 +483,6 @@ public async Task VerifyContainerCreateFile()
486483

487484
[Fact]
488485
[RequiresDocker]
489-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
490486
public async Task VerifyContainerStopStartWorks()
491487
{
492488
using var testProgram = CreateTestProgram("container-start-stop", randomizePorts: false);
@@ -574,7 +570,6 @@ public async Task VerifyExecutableStopStartWorks()
574570

575571
[Fact]
576572
[RequiresDocker]
577-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
578573
public async Task SpecifyingEnvPortInEndpointFlowsToEnv()
579574
{
580575
const string testName = "ports-flow-to-env";
@@ -631,7 +626,6 @@ public async Task SpecifyingEnvPortInEndpointFlowsToEnv()
631626
}
632627

633628
[Fact]
634-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
635629
public async Task StartAsync_DashboardAuthConfig_PassedToDashboardProcess()
636630
{
637631
const string testName = "dashboard-auth-config";
@@ -709,7 +703,6 @@ public async Task StartAsync_UnsecuredAllowAnonymous_PassedToDashboardProcess()
709703

710704
[Fact]
711705
[RequiresDocker]
712-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
713706
public async Task VerifyDockerWithEntrypointWorks()
714707
{
715708
const string testName = "docker-entrypoint";
@@ -738,7 +731,6 @@ public async Task VerifyDockerWithEntrypointWorks()
738731

739732
[Fact]
740733
[RequiresDocker]
741-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
742734
public async Task VerifyDockerWithBindMountWorksWithAbsolutePaths()
743735
{
744736
const string testName = "docker-bindmount-absolute";
@@ -769,7 +761,6 @@ public async Task VerifyDockerWithBindMountWorksWithAbsolutePaths()
769761

770762
[Fact]
771763
[RequiresDocker]
772-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
773764
public async Task VerifyDockerWithBindMountWorksWithRelativePaths()
774765
{
775766
const string testName = "docker-bindmount-relative";
@@ -800,7 +791,6 @@ public async Task VerifyDockerWithBindMountWorksWithRelativePaths()
800791

801792
[Fact]
802793
[RequiresDocker]
803-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
804794
public async Task VerifyDockerWithVolumeWorksWithName()
805795
{
806796
const string testName = "docker-volume";
@@ -830,7 +820,6 @@ public async Task VerifyDockerWithVolumeWorksWithName()
830820

831821
[Fact]
832822
[RequiresDocker]
833-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
834823
public async Task KubernetesHasResourceNameForContainersAndExes()
835824
{
836825
const string testName = "kube-resource-names";
@@ -888,7 +877,6 @@ public async Task KubernetesHasResourceNameForContainersAndExes()
888877
}
889878

890879
[Fact]
891-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
892880
public async Task ReplicasAndProxylessEndpointThrows()
893881
{
894882
const string testName = "replicas-no-proxyless-endpoints";
@@ -907,7 +895,6 @@ public async Task ReplicasAndProxylessEndpointThrows()
907895
}
908896

909897
[Fact]
910-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
911898
public async Task ProxylessEndpointWithoutPortThrows()
912899
{
913900
const string testName = "proxyess-endpoint-without-port";
@@ -927,7 +914,6 @@ public async Task ProxylessEndpointWithoutPortThrows()
927914
}
928915

929916
[Fact]
930-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
931917
public async Task ProxylessEndpointWorks()
932918
{
933919
const string testName = "proxyless-endpoint-works";
@@ -1031,7 +1017,6 @@ public async Task ProxylessAndProxiedEndpointBothWorkOnSameResource()
10311017

10321018
[Fact]
10331019
[RequiresDocker]
1034-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
10351020
public async Task ProxylessContainerCanBeReferenced()
10361021
{
10371022
const string testName = "proxyless-container";
@@ -1137,7 +1122,6 @@ public async Task WithEndpointProxySupportDisablesProxies()
11371122

11381123
[Fact]
11391124
[RequiresDocker]
1140-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
11411125
public async Task ProxylessContainerWithoutPortThrows()
11421126
{
11431127
const string testName = "proxyless-container-without-ports";
@@ -1156,7 +1140,6 @@ public async Task ProxylessContainerWithoutPortThrows()
11561140

11571141
[Fact]
11581142
[RequiresDocker]
1159-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
11601143
public async Task AfterResourcesCreatedLifecycleHookWorks()
11611144
{
11621145
const string testName = "lifecycle-hook-after-resource-created";

‎tests/Aspire.Hosting.Tests/Health/ResourceHealthCheckServiceTests.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
using System.Threading.Channels;
55
using Aspire.Hosting.Health;
66
using Aspire.Hosting.Utils;
7-
using Aspire.TestUtilities;
87
using Microsoft.AspNetCore.InternalTesting;
98
using Microsoft.Extensions.DependencyInjection;
109
using Microsoft.Extensions.Diagnostics.HealthChecks;
@@ -97,7 +96,6 @@ await app.ResourceNotifications.PublishUpdateAsync(resource.Resource, s => s wit
9796
}
9897

9998
[Fact]
100-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8326")]
10199
public async Task ResourcesWithHealthCheck_CreationErrorIsReported()
102100
{
103101
using var builder = TestDistributedApplicationBuilder.Create(testOutputHelper);
@@ -138,7 +136,6 @@ await app.ResourceNotifications.PublishUpdateAsync(resource.Resource, s => s wit
138136
}
139137

140138
[Fact]
141-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8103")]
142139
public async Task ResourcesWithHealthCheck_StopsAndRestartsMonitoringWithResource()
143140
{
144141
using var builder = TestDistributedApplicationBuilder.Create(testOutputHelper);

‎tests/Aspire.Hosting.Tests/OperationModesTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ namespace Aspire.Hosting.Tests;
1414
public class OperationModesTests(ITestOutputHelper outputHelper)
1515
{
1616
[Fact]
17-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8400")]
1817
public async Task VerifyBackwardsCompatableRunModeInvocation()
1918
{
2019
// The purpose of this test is to verify that the apphost executable will continue

‎tests/Aspire.Hosting.Tests/SlimTestProgramTests.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Licensed to the .NET Foundation under one or more agreements.
22
// The .NET Foundation licenses this file to you under the MIT license.
33

4-
using Aspire.TestUtilities;
54
using Aspire.Hosting.Testing.Tests;
65
using Microsoft.AspNetCore.InternalTesting;
76
using Xunit;
@@ -19,7 +18,6 @@ public SlimTestProgramTests(SlimTestProgramFixture slimTestProgramFixture)
1918
}
2019

2120
[Fact]
22-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/7923")]
2321
public async Task TestProjectStartsAndStopsCleanly()
2422
{
2523
var testProgram = _slimTestProgramFixture.TestProgram;
@@ -44,7 +42,6 @@ private static async Task EnsureServicesAreRunning(TestProgram testProgram, Canc
4442
}
4543

4644
[Fact]
47-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/7923")]
4845
public async Task TestPortOnEndpointAnnotationAndAllocatedEndpointAnnotationMatch()
4946
{
5047
var testProgram = _slimTestProgramFixture.TestProgram;
@@ -63,7 +60,6 @@ public async Task TestPortOnEndpointAnnotationAndAllocatedEndpointAnnotationMatc
6360
}
6461

6562
[Fact]
66-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/7923")]
6763
public async Task TestPortOnEndpointAnnotationAndAllocatedEndpointAnnotationMatchForReplicatedServices()
6864
{
6965
var testProgram = _slimTestProgramFixture.TestProgram;

‎tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@ public async Task WithHttpCommand_ResultsInExpectedResultForStatusCode(int statu
161161
[InlineData("get", true)]
162162
[InlineData("post", false)]
163163
[Theory]
164-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8514")]
165164
public async Task WithHttpCommand_ResultsInExpectedResultForHttpMethod(string? httpMethod, bool expectSuccess)
166165
{
167166
// Arrange
@@ -263,7 +262,6 @@ public async Task WithHttpCommand_UsesEndpointSelector()
263262
}
264263

265264
[Fact]
266-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8192")]
267265
public async Task WithHttpCommand_CallsPrepareRequestCallback_BeforeSendingRequest()
268266
{
269267
// Arrange
@@ -308,7 +306,6 @@ public async Task WithHttpCommand_CallsPrepareRequestCallback_BeforeSendingReque
308306
}
309307

310308
[Fact]
311-
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8200")]
312309
public async Task WithHttpCommand_CallsGetResponseCallback_AfterSendingRequest()
313310
{
314311
// Arrange

0 commit comments

Comments
 (0)