fix(cli): honor per-output preset import config (#10618)

* fix(cli): honor per-output preset import config

* chore: add changeset for cli preset config fix

* fix(cli): preserve root preset import settings

---------

Co-authored-by: Eddy Nguyen <ch@eddeee888.me>

Author: PalmerTurley34

.changeset/thin-bobcats-invite.md

@@ -0,0 +1,5 @@
+---
+'@graphql-codegen/cli': patch
+---
+
+Honor per-output preset `importExtension` and `emitLegacyCommonJSImports` config instead of always using the root config values.

packages/graphql-codegen-cli/src/codegen.ts

@@ -349,18 +349,24 @@ export async function executeCodegen(
                             })
                           );
 
-                          const importExtension = normalizeImportExtension({
+                          const rawMergedConfig = {
+                            ...rootConfig,
                             emitLegacyCommonJSImports: config.emitLegacyCommonJSImports,
                             importExtension: config.importExtension,
-                          });
-
-                          const mergedConfig = {
-                            ...rootConfig,
                             ...(typeof outputFileTemplateConfig === 'string'
                               ? { value: outputFileTemplateConfig }
                               : outputFileTemplateConfig),
+                          };
+
+                          const importExtension = normalizeImportExtension({
+                            emitLegacyCommonJSImports: rawMergedConfig.emitLegacyCommonJSImports,
+                            importExtension: rawMergedConfig.importExtension,
+                          });
+
+                          const mergedConfig = {
+                            ...rawMergedConfig,
                             importExtension,
-                            emitLegacyCommonJSImports: config.emitLegacyCommonJSImports ?? true,
+                            emitLegacyCommonJSImports: rawMergedConfig.emitLegacyCommonJSImports ?? true,
                           };
 
                           const documentTransforms = Array.isArray(outputConfig.documentTransforms)
@@ -412,7 +418,7 @@ export async function executeCodegen(
                             const output = await codegen({
                               ...outputArgs,
                               importExtension,
-                              emitLegacyCommonJSImports: config.emitLegacyCommonJSImports ?? true,
+                              emitLegacyCommonJSImports: rawMergedConfig.emitLegacyCommonJSImports ?? true,
                               cache,
                             });
                             result.push({

packages/graphql-codegen-cli/tests/codegen.spec.ts

@@ -259,6 +259,55 @@ describe('Codegen Executor', () => {
       expect(result[0].content).toContain('export type QQuery');
     });
 
+    it('Should inherit root importExtension and emitLegacyCommonJSImports for preset outputs and allow per-output overrides', async () => {
+      const recordingPreset = {
+        buildGeneratesSection: ({ baseOutputDir, config }) => [
+          {
+            filename: `${baseOutputDir}recorded-config.ts`,
+            pluginMap: {
+              recorder: {
+                plugin: (_schema, _documents, pluginConfig) =>
+                  JSON.stringify({
+                    importExtension: pluginConfig.importExtension,
+                    emitLegacyCommonJSImports: pluginConfig.emitLegacyCommonJSImports,
+                  }),
+              },
+            },
+            plugins: [{ recorder: {} }],
+            schema: parse(SIMPLE_TEST_SCHEMA),
+            documents: [],
+            config,
+          },
+        ],
+      };
+
+      const { result } = await executeCodegen({
+        schema: SIMPLE_TEST_SCHEMA,
+        documents: `query root { f }`,
+        emitLegacyCommonJSImports: false,
+        importExtension: '.mjs',
+        generates: {
+          './src/gql/': {
+            preset: recordingPreset,
+          },
+          './src/gql-with-override/': {
+            preset: recordingPreset,
+            config: {
+              importExtension: '.js',
+            },
+          },
+        },
+      });
+
+      expect(result).toHaveLength(2);
+
+      const inheritedOutput = result.find(file => file.filename === './src/gql/recorded-config.ts');
+      expect(inheritedOutput?.content).toBe(`{"importExtension":".mjs","emitLegacyCommonJSImports":false}`);
+
+      const overriddenOutput = result.find(file => file.filename === './src/gql-with-override/recorded-config.ts');
+      expect(overriddenOutput?.content).toBe(`{"importExtension":".js","emitLegacyCommonJSImports":false}`);
+    });
+
     it('Should return error on duplicated names', async () => {
       const { error } = await executeCodegen({
         schema: `