Merge pull request #704 from dorny/bugfix/703-refactor-deprecated-substr-function

Author: jozefizso

dist/index.js

@@ -242,13 +242,13 @@ export class DartJsonParser implements TestParser {
   private getRelativePath(path: string): string {
     const prefix = 'file://'
     if (path.startsWith(prefix)) {
-      path = path.substr(prefix.length)
+      path = path.substring(prefix.length)
     }
 
     path = normalizeFilePath(path)
     const workDir = this.getWorkDir(path)
     if (workDir !== undefined && path.startsWith(workDir)) {
-      path = path.substr(workDir.length)
+      path = path.substring(workDir.length)
     }
     return path
   }

src/parsers/dart-json/dart-json-parser.ts

@@ -136,7 +136,7 @@ export class DotnetNunitParser implements TestParser {
     path = normalizeFilePath(path)
     const workDir = this.getWorkDir(path)
     if (workDir !== undefined && path.startsWith(workDir)) {
-      path = path.substr(workDir.length)
+      path = path.substring(workDir.length)
     }
     return path
   }

src/parsers/dotnet-nunit/dotnet-nunit-parser.ts

@@ -94,7 +94,7 @@ export class DotnetTrxParser implements TestParser {
       const resultTestName = r.result.$.testName
       const testName =
         resultTestName.startsWith(className) && resultTestName[className.length] === '.'
-          ? resultTestName.substr(className.length + 1)
+          ? resultTestName.substring(className.length + 1)
           : resultTestName
 
       const test = new Test(testName, r.result.$.outcome, duration, error)
@@ -177,7 +177,7 @@ export class DotnetTrxParser implements TestParser {
         const filePath = normalizeFilePath(fileStr)
         const workDir = this.getWorkDir(filePath)
         if (workDir) {
-          const file = filePath.substr(workDir.length)
+          const file = filePath.substring(workDir.length)
           if (trackedFiles.includes(file)) {
             const line = parseInt(lineStr)
             return {path: file, line}

src/parsers/dotnet-trx/dotnet-trx-parser.ts

@@ -106,7 +106,7 @@ export class JestJunitParser implements TestParser {
     path = normalizeFilePath(path)
     const workDir = this.getWorkDir(path)
     if (workDir !== undefined && path.startsWith(workDir)) {
-      path = path.substr(workDir.length)
+      path = path.substring(workDir.length)
     }
     return path
   }

src/parsers/jest-junit/jest-junit-parser.ts

@@ -61,7 +61,7 @@ export class MochaJsonParser implements TestParser {
   private processTest(suite: TestSuiteResult, test: MochaJsonTest, result: TestExecutionResult): void {
     const groupName =
       test.fullTitle !== test.title
-        ? test.fullTitle.substr(0, test.fullTitle.length - test.title.length).trimEnd()
+        ? test.fullTitle.substring(0, test.fullTitle.length - test.title.length).trimEnd()
         : null
 
     let group = suite.groups.find(grp => grp.name === groupName)
@@ -103,7 +103,7 @@ export class MochaJsonParser implements TestParser {
     path = normalizeFilePath(path)
     const workDir = this.getWorkDir(path)
     if (workDir !== undefined && path.startsWith(workDir)) {
-      path = path.substr(workDir.length)
+      path = path.substring(workDir.length)
     }
     return path
   }

src/parsers/mocha-json/mocha-json-parser.ts

@@ -208,7 +208,7 @@ export class PhpunitJunitParser implements TestParser {
     path = normalizeFilePath(path)
     const workDir = this.getWorkDir(path)
     if (workDir !== undefined && path.startsWith(workDir)) {
-      path = path.substr(workDir.length)
+      path = path.substring(workDir.length)
     }
     return path
   }

src/parsers/phpunit-junit/phpunit-junit-parser.ts

@@ -55,7 +55,7 @@ export class RspecJsonParser implements TestParser {
   private processTest(suite: TestSuiteResult, test: RspecExample, result: TestExecutionResult): void {
     const groupName =
       test.full_description !== test.description
-        ? test.full_description.substr(0, test.full_description.length - test.description.length).trimEnd()
+        ? test.full_description.substring(0, test.full_description.length - test.description.length).trimEnd()
         : null
 
     let group = suite.groups.find(grp => grp.name === groupName)

src/parsers/rspec-json/rspec-json-parser.ts

@@ -36,7 +36,7 @@ export function ellipsis(text: string, maxLength: number): string {
     return text
   }
 
-  return text.substr(0, maxLength - 3) + '...'
+  return text.substring(0, maxLength - 3) + '...'
 }
 
 export function formatTime(ms: number): string {

src/utils/markdown-utils.ts

@@ -34,6 +34,6 @@ export function getBasePath(path: string, trackedFiles: string[]): string | unde
     return undefined
   }
 
-  const base = path.substr(0, path.length - max.length)
+  const base = path.substring(0, path.length - max.length)
   return base
 }