Skip to content

Commit d4dad18

Browse files
committed
Update the reference parsing logic to match what common tools do today (e.g. Docker CLI)
1 parent 2d365b6 commit d4dad18

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

ociref/dockerhub.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
package ociref
2+
3+
var dockerHubHosts = map[string]bool{
4+
"": true,
5+
"docker.io": true,
6+
"index.docker.io": true,
7+
"registry-1.docker.io": true,
8+
"registry.hub.docker.com": true,
9+
}

ociref/reference.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ func ParseRelative(refStr string) (Reference, error) {
195195
return Reference{}, fmt.Errorf("invalid digest %q: %v", ref.Digest, err)
196196
}
197197
}
198-
if ref.Host == "" {
198+
if dockerHubHosts[ref.Host] {
199199
ref.Host = "docker.io"
200200
}
201201
if len(ref.Repository) > 255 {

0 commit comments

Comments
 (0)