fix race in serializing sandbox to string#1495
Merged
sanimej merged 1 commit intomoby:masterfrom Oct 13, 2016
LK4D4:fix_sb_race
Merged
fix race in serializing sandbox to string#1495sanimej merged 1 commit intomoby:masterfrom LK4D4:fix_sb_race
sanimej merged 1 commit intomoby:masterfrom
LK4D4:fix_sb_race
Conversation
aboch
reviewed
Oct 7, 2016
| if !s.isStub { | ||
| err = types.ForbiddenErrorf("container %s is already present: %v", containerID, s) | ||
| c.Unlock() | ||
| return nil, types.ForbiddenErrorf("container %s is already present: %v", containerID, s) |
Contributor
There was a problem hiding this comment.
Given this is a very unlikely error and given sandbox does not implement the String() method, there is no much value in printing the whole raw structure. I am thinking we can avoid the issue and just change the error format to
(container %s is already present in sandbox %s", containerID, s.ID())
Contributor
Author
There was a problem hiding this comment.
I'm ok with changing format, but s.ID() is still not goroutine-safe, so I would need to do it under lock.
Contributor
There was a problem hiding this comment.
Ah, thanks did not notice s.ID() is not goroutine-safe, feel free to change it, I think iit is a safe change. Or stick with your last suggestion. Up to you.
Signed-off-by: Alexander Morozov <lk4d4math@gmail.com>
Contributor
Author
|
@aboch Updated! |
Contributor
|
LGTM |
|
LGTM |
liusdu
pushed a commit
to liusdu/moby
that referenced
this pull request
Oct 30, 2017
moby/libnetwork#1495 Signed-off-by: Alexander Morozov <lk4d4math@gmail.com> Signed-off-by: Lei Jitang <leijitang@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ping @mrjana @aboch @sanimej