Skip to content

Improve history #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rumpl merged 1 commit into from
Jan 20, 2026
Merged

Improve history #1429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions pkg/history/history.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
package history

import (
"bytes"
"encoding/json"
"os"
"path/filepath"
"slices"
"strings"

"github.com/natefinch/atomic"
)

type History struct {
Expand Down Expand Up @@ -54,15 +58,10 @@ func New(opts ...Opt) (*History, error) {

func (h *History) Add(message string) error {
// Add the message last but avoid duplicate messages
var messages []string
for _, msg := range h.Messages {
if msg != message {
messages = append(messages, msg)
}
}
messages = append(messages, message)

h.Messages = messages
h.Messages = slices.DeleteFunc(h.Messages, func(m string) bool {
return m == message
})
h.Messages = append(h.Messages, message)
h.current = len(h.Messages)

return h.save()
Expand Down Expand Up @@ -131,7 +130,7 @@ func (h *History) save() error {
return err
}

return os.WriteFile(h.path, data, 0o644)
return atomic.WriteFile(h.path, bytes.NewReader(data))
}

func (h *History) load() error {
Expand Down