[6.0.x] Fixed CVE-2026-6873 -- Prevented signed cookie salt namespace collisions.

Made signed cookies derive their signer namespace from an injective
encoding of `(name, salt)` while preserving compatibility with legacy
`name + salt` cookies behind SIGNED_COOKIE_LEGACY_SALT_FALLBACK.

Thanks Peng Zhou for the report, and Shai Berger, Markus Holterman,
Jake Howard, and Paul McMillan for reviews.

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>

Backport of 70d3651 from main.

Author: PaulMcMillan

django/conf/global_settings.py

@@ -550,6 +550,7 @@ def gettext_noop(s):
 # SIGNING #
 ###########
 
+SIGNED_COOKIE_LEGACY_SALT_FALLBACK = True
 SIGNING_BACKEND = "django.core.signing.TimestampSigner"
 
 ########

django/core/signing.py

@@ -107,6 +107,30 @@ def _cookie_signer_key(key):
     return b"django.http.cookies" + force_bytes(key)
 
 
+def _cookie_signer_salt(cookie_name, salt=""):
+    # Prefix the salt length so (cookie_name, salt) pairs can't collide.
+    return f"django.http.cookies.v2:{len(salt)}:{salt}{cookie_name}"
+
+
+def _cookie_signer_legacy_salt(cookie_name, salt=""):
+    return cookie_name + salt
+
+
+def _unsign_cookie(signed_value, *, cookie_name, salt="", max_age=None):
+    try:
+        return get_cookie_signer(salt=_cookie_signer_salt(cookie_name, salt)).unsign(
+            signed_value, max_age=max_age
+        )
+    except BadSignature as exc:
+        if settings.SIGNED_COOKIE_LEGACY_SALT_FALLBACK and not isinstance(
+            exc, SignatureExpired
+        ):
+            return get_cookie_signer(
+                salt=_cookie_signer_legacy_salt(cookie_name, salt)
+            ).unsign(signed_value, max_age=max_age)
+        raise
+
+
 def get_cookie_signer(salt="django.core.signing.get_cookie_signer"):
     Signer = import_string(settings.SIGNING_BACKEND)
     return Signer(

django/http/request.py

@@ -246,8 +246,8 @@ def get_signed_cookie(self, key, default=RAISE_ERROR, salt="", max_age=None):
             else:
                 raise
         try:
-            value = signing.get_cookie_signer(salt=key + salt).unsign(
-                cookie_value, max_age=max_age
+            value = signing._unsign_cookie(
+                cookie_value, cookie_name=key, salt=salt, max_age=max_age
             )
         except signing.BadSignature:
             if default is not RAISE_ERROR:

django/http/response.py

@@ -284,7 +284,9 @@ def setdefault(self, key, value):
         self.headers.setdefault(key, value)
 
     def set_signed_cookie(self, key, value, salt="", **kwargs):
-        value = signing.get_cookie_signer(salt=key + salt).sign(value)
+        value = signing.get_cookie_signer(
+            salt=signing._cookie_signer_salt(key, salt)
+        ).sign(value)
         return self.set_cookie(key, value, **kwargs)
 
     def delete_cookie(self, key, path="/", domain=None, samesite=None):

docs/ref/request-response.txt

@@ -395,11 +395,14 @@ Methods
     no longer valid. If you provide the ``default`` argument the exception
     will be suppressed and that default value will be returned instead.
 
-    The optional ``salt`` argument can be used to provide extra protection
-    against brute force attacks on your secret key. If supplied, the
-    ``max_age`` argument will be checked against the signed timestamp
-    attached to the cookie value to ensure the cookie is not older than
-    ``max_age`` seconds.
+    The optional ``salt`` argument can be used to put the cookie into a
+    separate signature namespace. If supplied, the ``max_age`` argument will
+    be checked against the signed timestamp attached to the cookie value to
+    ensure the cookie is not older than ``max_age`` seconds.
+
+    Cookies signed by older Django versions are accepted by default for
+    backwards compatibility. Set :setting:`SIGNED_COOKIE_LEGACY_SALT_FALLBACK`
+    to ``False`` to reject them.
 
     For example:
 
@@ -422,6 +425,11 @@ Methods
 
     See :doc:`cryptographic signing </topics/signing>` for more information.
 
+    .. versionchanged:: 5.2.15
+
+        In older versions, cookies signed with distinct ``(key, salt)`` pairs
+        that concatenate to the same string could be used interchangeably.
+
 .. method:: HttpRequest.is_secure()
 
     Returns ``True`` if the request is secure; that is, if it was made with
@@ -1046,8 +1054,9 @@ Methods
     Like :meth:`~HttpResponse.set_cookie`, but
     :doc:`cryptographic signing </topics/signing>` the cookie before setting
     it. Use in conjunction with :meth:`HttpRequest.get_signed_cookie`.
-    You can use the optional ``salt`` argument for added key strength, but
-    you will need to remember to pass it to the corresponding
+    You can use the optional ``salt`` argument to put the cookie into a
+    separate signature namespace, but you will need to remember to pass it to
+    the corresponding
     :meth:`HttpRequest.get_signed_cookie` call.
 
 .. method:: HttpResponse.delete_cookie(key, path='/', domain=None, samesite=None)

docs/ref/settings.txt

@@ -2698,6 +2698,24 @@ precedence and will be applied instead. See
 
 See also :setting:`DATE_FORMAT` and :setting:`SHORT_DATE_FORMAT`.
 
+.. setting:: SIGNED_COOKIE_LEGACY_SALT_FALLBACK
+
+``SIGNED_COOKIE_LEGACY_SALT_FALLBACK``
+---------------------------------------
+
+.. versionadded:: 5.2.15
+
+Default: ``True``
+
+Controls whether :meth:`~django.http.HttpRequest.get_signed_cookie` accepts
+cookies signed with Django's historical signed-cookie salt derivation based on
+``key + salt``.
+
+Set this to ``False`` to reject those legacy signed cookies and only accept
+cookies signed with Django's current unambiguous signed-cookie salt derivation.
+This transitional setting will be removed in Django 7.0, when the legacy signed
+cookies will no longer be accepted.
+
 .. setting:: SIGNING_BACKEND
 
 ``SIGNING_BACKEND``
@@ -3931,6 +3949,7 @@ HTTP
   * :setting:`SECURE_REFERRER_POLICY`
   * :setting:`SECURE_SSL_HOST`
   * :setting:`SECURE_SSL_REDIRECT`
+* :setting:`SIGNED_COOKIE_LEGACY_SALT_FALLBACK`
 * :setting:`SIGNING_BACKEND`
 * :setting:`USE_X_FORWARDED_HOST`
 * :setting:`USE_X_FORWARDED_PORT`

docs/releases/5.2.15.txt

@@ -5,3 +5,20 @@ Django 5.2.15 release notes
 *June 3, 2026*
 
 Django 5.2.15 fixes five security issues with severity "low" in 5.2.14.
+
+CVE-2026-6873: Signed cookie salt namespace collision
+=====================================================
+
+:meth:`~django.http.HttpRequest.get_signed_cookie` derived the signing salt by
+concatenating the cookie name (``key``) and ``salt`` arguments. When distinct
+name and salt pairs produced the same concatenation, cookies could be accepted
+in a context different from the one where they were signed.
+
+Cookies are now signed with an unambiguous salt derivation. For backwards
+compatibility, cookies signed by older Django versions are accepted until
+Django 7.0. Projects affected by the above ambiguity should set
+:setting:`SIGNED_COOKIE_LEGACY_SALT_FALLBACK` to ``False`` to reject older
+cookies immediately.
+
+This issue has severity "low" according to the :ref:`Django security policy
+<severity-levels>`.

docs/releases/6.0.6.txt

@@ -7,6 +7,23 @@ Django 6.0.6 release notes
 Django 6.0.6 fixes five security issues with severity "low" and one bug in
 6.0.5.
 
+CVE-2026-6873: Signed cookie salt namespace collision
+=====================================================
+
+:meth:`~django.http.HttpRequest.get_signed_cookie` derived the signing salt by
+concatenating the cookie name (``key``) and ``salt`` arguments. When distinct
+name and salt pairs produced the same concatenation, cookies could be accepted
+in a context different from the one where they were signed.
+
+Cookies are now signed with an unambiguous salt derivation. For backwards
+compatibility, cookies signed by older Django versions are accepted until
+Django 7.0. Projects affected by the above ambiguity should set
+:setting:`SIGNED_COOKIE_LEGACY_SALT_FALLBACK` to ``False`` to reject older
+cookies immediately.
+
+This issue has severity "low" according to the :ref:`Django security policy
+<severity-levels>`.
+
 Bugfixes
 ========
 

tests/signed_cookies_tests/tests.py

@@ -6,6 +6,7 @@
 from django.test.utils import freeze_time
 
 
+@override_settings(SIGNED_COOKIE_LEGACY_SALT_FALLBACK=False)
 class SignedCookieTest(SimpleTestCase):
     def test_can_set_and_read_signed_cookies(self):
         response = HttpResponse()
@@ -27,6 +28,55 @@ def test_can_use_salt(self):
         with self.assertRaises(signing.BadSignature):
             request.get_signed_cookie("a", salt="two")
 
+    def test_salt_namespace_is_unambiguous(self):
+        response = HttpResponse()
+        response.set_signed_cookie("a", "hello", salt="bc")
+        request = HttpRequest()
+        request.COOKIES["ab"] = response.cookies["a"].value
+        with self.assertRaises(signing.BadSignature):
+            request.get_signed_cookie("ab", salt="c")
+
+    @override_settings(SIGNED_COOKIE_LEGACY_SALT_FALLBACK=True)
+    def test_expired_legacy_cookie_raises_signature_expired(self):
+        with freeze_time(123456789):
+            request = HttpRequest()
+            request.COOKIES["a"] = signing.get_cookie_signer(
+                salt=signing._cookie_signer_legacy_salt("a", "bc")
+            ).sign("hello")
+        with freeze_time(123456800):
+            with self.assertRaises(signing.SignatureExpired):
+                request.get_signed_cookie("a", salt="bc", max_age=10)
+
+    @override_settings(SIGNED_COOKIE_LEGACY_SALT_FALLBACK=True)
+    def test_legacy_salt_namespace_is_accepted_by_default(self):
+        request = HttpRequest()
+        # Simulate an attack along the lines of CVE-2026-6873, where a value
+        # for the "a" cookie is submitted as the value for another cookie.
+        request.COOKIES["ab"] = signing.get_cookie_signer(
+            salt=signing._cookie_signer_legacy_salt("a", "bc")
+        ).sign("hello")
+        # No protection since SIGNED_COOKIE_LEGACY_SALT_FALLBACK=True.
+        self.assertEqual(request.get_signed_cookie("ab", salt="c"), "hello")
+
+    def test_legacy_salt_namespace_not_accepted(self):
+        request = HttpRequest()
+        request.COOKIES["a"] = signing.get_cookie_signer(
+            salt=signing._cookie_signer_legacy_salt("a", "bc")
+        ).sign("hello")
+        with self.assertRaises(signing.BadSignature):
+            request.get_signed_cookie("a", salt="bc")
+
+    @override_settings(SIGNED_COOKIE_LEGACY_SALT_FALLBACK=True)
+    def test_expired_new_style_cookie_does_not_fallback_to_legacy_salt(self):
+        with freeze_time(123456789):
+            response = HttpResponse()
+            response.set_signed_cookie("a", "hello", salt="bc")
+        request = HttpRequest()
+        request.COOKIES["a"] = response.cookies["a"].value
+        with freeze_time(123456800):
+            with self.assertRaises(signing.SignatureExpired):
+                request.get_signed_cookie("a", salt="bc", max_age=10)
+
     def test_detects_tampering(self):
         response = HttpResponse()
         response.set_signed_cookie("c", "hello")