Verilog: lowering for concatenation of aval/bval encoded vectors #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested changes
Jun 21, 2024
src/verilog/aval_bval_encoding.cpp
Outdated
| if(is_aval_bval(src.type())) | ||
| { | ||
| auto width = aval_bval_width(src.type()); | ||
| return extractbits_exprt{src, 0, bv_typet{width}}; |
There was a problem hiding this comment.
Shouldn't this be width instead of 0? (Can we have a test that catches this?)
src/verilog/aval_bval_encoding.cpp
Outdated
| { | ||
| // zeros, signaling 0/1 | ||
| auto width = to_bitvector_type(src.type()).get_width(); | ||
| return from_integer(0, bv_typet{width}); |
There was a problem hiding this comment.
Maybe throw in a cbmc upgrade and use the new bv_typet methods?
kroening
force-pushed
the
aval-bval-concatenation
branch
3 times, most recently
from
2ab45ea to
8fc936e
Compare
This adds lowering for the concatenation of aval/bval encoded bit-vectors.
kroening
force-pushed
the
aval-bval-concatenation
branch
from
8fc936e to
b80d107
Compare
tautschnig
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds lowering for the concatenation of aval/bval encoded bit-vectors.