bv_pointert cleanup #6830
Merged
bv_pointert cleanup #6830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Apr 26, 2022
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
This commit moves three methods that have (relatively) large bodies from the header file into the .cpp file.
There is no need for a pointer-aware bv_width class, as pointers are bitvector types (including a width) since 2016.
This removes various obvious declarators from method declarations in bv_pointerst.
kroening
requested review from
martin-cs,
tautschnig and
peterschrammel
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #6830 +/- ##
===========================================
+ Coverage 77.01% 77.02% +0.01%
===========================================
Files 1594 1594
Lines 184954 184991 +37
===========================================
+ Hits 142438 142490 +52
+ Misses 42516 42501 -15
Continue to review full report at Codecov.
|
tautschnig
reviewed
Apr 26, 2022
| @@ -68,58 +68,33 @@ void bv_endianness_mapt::build_big_endian(const typet &src) | |||
| endianness_mapt | |||
| bv_pointerst::endianness_map(const typet &type, bool little_endian) const | |||
| { | |||
| return bv_endianness_mapt{type, little_endian, ns, bv_pointers_width}; | |||
| return bv_endianness_mapt{type, little_endian, ns, bv_width}; | |||
There was a problem hiding this comment.
That second commit is a part-revert of 5cf2b07. If we go for removing the capability that the commit was trying to add we should ponder a clean revert instead.
There was a problem hiding this comment.
We absolutely want to keep the parts of that commit that pass the pointer type around!
tautschnig
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.