Skip to content

Use non-trivial constructor of code_function_callt [blocks: #3800] #3885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2019
Merged

Use non-trivial constructor of code_function_callt [blocks: #3800] #3885

merged 1 commit into from
Jan 23, 2019

Conversation

tautschnig
Copy link
Collaborator

This is more efficient and type safe.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig
Use non-trivial constructor of code_function_callt
e4b09e7 
This is more efficient and type safe.
allredj
allredj reviewed Jan 21, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: e4b09e7).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98087928

@tautschnig tautschnig merged commit e2a5430 into diffblue:develop Jan 23, 2019
@tautschnig tautschnig deleted the deprecation-code_function_callt branch January 23, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroening kroening kroening approved these changes

@peterschrammel peterschrammel peterschrammel approved these changes

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

+1 more reviewer

@allredj allredj allredj left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@tautschnig tautschnig

Labels
blocker cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tautschnig @kroening @peterschrammel @allredj