type_with_subtypest now has constructors that take the subtypes #3159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Oct 14, 2018
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- My contribution is formatted in line with CODING_STANDARD.md.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
kroening
requested review from
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
allredj
reviewed
Oct 14, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 3d53d3e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87880016
smowton
approved these changes
Oct 14, 2018
tautschnig
reviewed
Oct 14, 2018
src/util/type.h
Outdated
| typet(_id) { subtypes()=_subtypes; } | ||
|
|
||
| type_with_subtypest(const irep_idt &_id, subtypest &&_subtypes): | ||
| typet(_id) { subtypes()=std::move(_subtypes); } |
There was a problem hiding this comment.
Nit picking: would it be possible to fix the formatting?
kroening
force-pushed
the
type_with_subtypes_constructor
branch
from
3d53d3e to
e3bbd58
Compare
allredj
reviewed
Oct 14, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: e3bbd58).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87890142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.