From ffe02e48f2b3b5fcfb3888e3299f079b89c58345 Mon Sep 17 00:00:00 2001 From: Chris Smowton Date: Sat, 11 Nov 2017 20:24:24 +0000 Subject: [PATCH] Remove useless cmdlinet::clear() call In cmdlinet this clears vectors that are about to die anyway, and because it is called in a destructor it cannot dispatch to a child class. By removing this call we can disabuse any extending child of the false expectation that their derived clear() method will in fact be called. --- src/util/cmdline.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/cmdline.cpp b/src/util/cmdline.cpp index a71ca546879..ef61ff89a78 100644 --- a/src/util/cmdline.cpp +++ b/src/util/cmdline.cpp @@ -18,7 +18,6 @@ cmdlinet::cmdlinet() cmdlinet::~cmdlinet() { - clear(); } void cmdlinet::clear()