Do not create a reference when building a new object

by bad: will be squashed.

Author: petr-bauch

src/goto-harness/recursive_initialization.cpp

@@ -554,7 +554,7 @@ code_blockt recursive_initializationt::build_pointer_constructor(
   const symbol_exprt &local_result =
     get_fresh_local_typed_symexpr("local_result", type, nullptr_expr);
   then_case.add(code_declt{local_result});
-  const namespacet &ns{goto_model.symbol_table};
+  const namespacet ns{goto_model.symbol_table};
   then_case.add(code_function_callt{
     local_result, get_malloc_function(), {*size_of_expr(type.subtype(), ns)}});
   initialize(
@@ -631,7 +631,7 @@ code_blockt recursive_initializationt::build_struct_constructor(
   const typet &struct_type = result.type().subtype();
   PRECONDITION(struct_type.id() == ID_struct_tag);
   code_blockt body{};
-  const namespacet &ns{goto_model.symbol_table};
+  const namespacet ns{goto_model.symbol_table};
   for(const auto &component :
       ns.follow_tag(to_struct_tag_type(struct_type)).components())
   {
@@ -693,7 +693,7 @@ code_blockt recursive_initializationt::build_dynamic_array_constructor(
   const symbol_exprt &local_result =
     get_fresh_local_typed_symexpr("local_result", pointer_type, exprt{});
   body.add(code_declt{local_result});
-  const namespacet &ns{goto_model.symbol_table};
+  const namespacet ns{goto_model.symbol_table};
   for(auto array_size = min_array_size; array_size <= max_array_size;
       ++array_size)
   {