WIP add additional regression tests

Author: hannes-steffenhagen-diffblue

regression/goto-instrument/replace-function-body-const-pointer-to-non-const/main.c

@@ -0,0 +1,12 @@
+#include <assert.h>
+
+void change_pointer_target_of_const_pointer(
+  int *const constant_pointer_to_nonconst);
+
+int main(void)
+{
+  int x = 10;
+  change_pointer_target_of_const_pointer(&x);
+  assert(x == 10);
+  return 0;
+}

regression/goto-instrument/replace-function-body-const-pointer-to-non-const/test.desc

@@ -0,0 +1,7 @@
+CORE
+main.c
+--replace-function-body change_pointer_target_of_const_pointer --replace-function-body-options havoc,params:.*
+^EXIT=10$
+^SIGNAL=0$
+^\[main.assertion.1\] assertion x == 10: FAILURE$
+--

regression/goto-instrument/replace-function-body-pointer-to-pointer-to-const/main.c

@@ -0,0 +1,14 @@
+#include <assert.h>
+
+void change_target_of_pointer_to_pointer_to_const(
+  const int **pointer_to_pointer_to_const);
+
+int main(void)
+{
+  int x = 10;
+  int *px = &x;
+  assert(*px == 10);
+  change_target_of_pointer_to_pointer_to_const(&px);
+  assert(x == 10);
+  assert(*px == 10);
+}

regression/goto-instrument/replace-function-body-pointer-to-pointer-to-const/test.desc

@@ -0,0 +1,9 @@
+CORE
+main.c
+--replace-function-body change_target_of_pointer_to_pointer_to_const --replace-function-body-options havoc,params:.*
+^EXIT=10$
+^SIGNAL=0$
+^\[main.assertion.1\] assertion \*px == 10: SUCCESS$
+^\[main.assertion.2\] assertion x == 10: SUCCESS$
+^\[main.assertion.3\] assertion \*px == 10: FAILURE$
+--

src/goto-programs/replace_function_bodies.cpp

@@ -70,8 +70,8 @@ class assume_false_replace_function_bodiest : public replace_function_bodiest
     const irep_idt &function_name) override
   {
     auto const &function_symbol = symbol_table.lookup_ref(function_name);
-    auto add_instruction = [&]()
-    {
+    // NOLINTNEXTLINE
+    auto add_instruction = [&]() {
       auto instruction = function.body.add_instruction();
       instruction->function = function_name;
       instruction->source_location = function_symbol.location;
@@ -93,8 +93,8 @@ class assert_false_replace_function_bodiest : public replace_function_bodiest
     const irep_idt &function_name) override
   {
     auto const &function_symbol = symbol_table.lookup_ref(function_name);
-    auto add_instruction = [&]()
-    {
+    // NOLINTNEXTLINE
+    auto add_instruction = [&]() {
       auto instruction = function.body.add_instruction();
       instruction->function = function_name;
       instruction->source_location = function_symbol.location;
@@ -124,8 +124,8 @@ class assert_false_then_assume_false_replace_function_bodiest
     const irep_idt &function_name) override
   {
     auto const &function_symbol = symbol_table.lookup_ref(function_name);
-    auto add_instruction = [&]()
-    {
+    // NOLINTNEXTLINE
+    auto add_instruction = [&]() {
       auto instruction = function.body.add_instruction();
       instruction->function = function_name;
       instruction->source_location = function_symbol.location;
@@ -178,8 +178,8 @@ class havoc_replace_function_bodiest : public replace_function_bodiest
     const irep_idt &function_name) override
   {
     auto const &function_symbol = symbol_table.lookup_ref(function_name);
-    auto add_instruction = [&]()
-    {
+    // NOLINTNEXTLINE
+    auto add_instruction = [&]() {
       auto instruction = function.body.add_instruction();
       instruction->function = function_name;
       instruction->source_location = function_symbol.location;
@@ -241,8 +241,7 @@ class havoc_replace_function_bodiest : public replace_function_bodiest
 class replace_function_bodies_errort : public std::runtime_error
 {
 public:
-  explicit replace_function_bodies_errort(
-    const std::string &reason)
+  explicit replace_function_bodies_errort(const std::string &reason)
     : runtime_error(reason)
   {
   }

src/goto-programs/replace_function_bodies.h

@@ -10,8 +10,7 @@ Author: DiffBlue Ltd.
 #define CPROVER_GOTO_PROGRAMS_REPLACE_FUNCTION_BODIES_H
 
 #include <regex>
-#include <vector>
-#include <iostream>
+#include <memory>
 
 #include <goto-programs/goto_functions.h>
 #include <util/std_code.h>