fix potential non-zero termination of a string buffer

Author: kroening

src/util/tempdir.cpp

@@ -12,6 +12,8 @@ Author: CM Wintersteiger
 #include <windows.h>
 #include <io.h>
 #include <direct.h>
+#else
+#include <vector>
 #endif
 
 #include <cstdlib>
@@ -64,9 +66,11 @@ std::string get_temporary_directory(const std::string &name_template)
       prefixed_name_template+='/';
     prefixed_name_template+=name_template;
 
-    char t[1000];
-    strncpy(t, prefixed_name_template.c_str(), 1000);
-    const char *td = mkdtemp(t);
+    std::vector<char> t;
+    // add one byte for the zero
+    t.resize(prefixed_name_template.size()+1);
+    memcpy(t.data(), prefixed_name_template.c_str(), t.size());
+    const char *td = mkdtemp(t.data());
     if(!td)
       throw "mkdtemp failed";
     result=std::string(td);