Adding a unit test for specialisation of implicitly generic classes

Author: svorenova

unit/java_bytecode/generate_concrete_generic_type/generate_java_generic_type.cpp

@@ -19,7 +19,8 @@ SCENARIO(
   "generate_java_generic_type_from_file",
   "[core][java_bytecode][generate_java_generic_type]")
 {
-  auto expected_symbol = "java::generic_two_fields$bound_element<Integer>";
+  auto expected_symbol =
+    "java::generic_two_fields$bound_element<java::java.lang.Integer>";
 
   GIVEN("A generic java type with two generic fields and a concrete "
           "substitution")
@@ -35,7 +36,7 @@ SCENARIO(
     THEN("The class should contain two instantiated fields.")
     {
       const auto &class_symbol = new_symbol_table.lookup(
-        "java::generic_two_fields$bound_element<Integer>");
+        "java::generic_two_fields$bound_element<java::java.lang.Integer>");
       const typet &symbol_type=class_symbol->type;
 
       REQUIRE(symbol_type.id()==ID_struct);
@@ -68,7 +69,8 @@ SCENARIO(
   "[core][java_bytecode][generate_java_generic_type]")
 {
   auto expected_symbol =
-    "java::generic_two_parameters$KeyValuePair<String, Integer>";
+    "java::generic_two_parameters$KeyValuePair<java::java.lang.String, "
+    "java::java.lang.Integer>";
 
   GIVEN("A generic java type with two generic parameters, like a Hashtable")
   {
@@ -109,8 +111,10 @@ SCENARIO(
   // After we have loaded the class and converted the generics,
   // the presence of these two symbols in the symbol table is
   // proof enough that we did the work we needed to do correctly.
-  auto first_expected_symbol = "java::generic_two_instances$element<Boolean>";
-  auto second_expected_symbol = "java::generic_two_instances$element<Integer>";
+  auto first_expected_symbol =
+    "java::generic_two_instances$element<java::java.lang.Boolean>";
+  auto second_expected_symbol =
+    "java::generic_two_instances$element<java::java.lang.Integer>";
 
   GIVEN("A generic java type with a field that refers to another generic with"
           " an uninstantiated parameter.")
@@ -204,8 +208,7 @@ SCENARIO(
     {
       const irep_idt test_class_integer =
         "java::generic_field_array_instantiation$generic<array[reference]"
-        "of_"
-        "java::java.lang.Integer>";
+        "of_java::java.lang.Integer>";
 
       const irep_idt test_class_int =
         "java::generic_field_array_instantiation$generic<array[int]>";
@@ -258,8 +261,9 @@ SCENARIO(
         "There should be a specialised version of the class in the symbol "
         "table")
       {
-        const irep_idt specialised_class_name =
-          id2string(harness_class) + "$" + id2string(inner_class) + "<Float>";
+        const irep_idt specialised_class_name = id2string(harness_class) + "$" +
+                                                id2string(inner_class) +
+                                                "<java::java.lang.Float>";
         REQUIRE(new_symbol_table.has_symbol(specialised_class_name));
 
         const symbolt test_class_symbol =
@@ -309,8 +313,7 @@ SCENARIO(
         "table")
       {
         const std::string specialised_string =
-          "<array[reference]of_"
-          "java::java.lang.Float>";
+          "<array[reference]of_java::java.lang.Float>";
         const irep_idt specialised_class_name = id2string(harness_class) + "$" +
                                                 id2string(inner_class) +
                                                 specialised_string;