Skip to content

Conversation

@maehr
Copy link
Collaborator

@maehr maehr commented Oct 29, 2021

@maehr
Copy link
Collaborator Author

maehr commented Nov 10, 2021

Hello all. I have not received any response from any maintainer. What do you think @diegosiqueir4 about my PR?
Thank you very much and best regards
Moritz

@jdamerow
Copy link
Member

Hi @maehr, this is great! Sorry for being slow, we just don't have a formal process for PRs yet. Let me get someone else to also have a look at it and then it should be good to go.

@jdamerow jdamerow self-requested a review November 10, 2021 16:33
@maehr
Copy link
Collaborator Author

maehr commented Nov 16, 2021

@jdamerow thanks for approving my PR.
Cheers
Moritz

@maehr
Copy link
Collaborator Author

maehr commented Nov 29, 2021

@jdamerow Hi there
Do you plan to merge my PR?
Best, moritz

@robcast robcast merged commit b8b0a99 into dh-tech:master Nov 29, 2021
@diegosiqueir4
Copy link
Member

Hello all. I have not received any response from any maintainer. What do you think @diegosiqueir4 about my PR? Thank you very much and best regards Moritz

Hello @maehr,
sorry for the delay in responding. I was on vacation and only now was able to process all my messages. Glad to see that PR has already been merged with master. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants