Skip to content

feat(cdc): Add support for SCRAM SASL mechanism#7765

Merged
ahsanbarkati merged 6 commits intomasterfrom
ahsan/sasl
Apr 30, 2021
Merged

feat(cdc): Add support for SCRAM SASL mechanism#7765
ahsanbarkati merged 6 commits intomasterfrom
ahsan/sasl

Conversation

@ahsanbarkati
Copy link
Copy Markdown
Contributor

@ahsanbarkati ahsanbarkati commented Apr 29, 2021

We used to support only the PLAIN mechanism for SASL in cdc-kafka.
This PR adds support for SCRAM-SHA-256 and SCRAM-SHA-512.

We can specify the mechanism by the sasl-mechanism sub flag under the --cdc superflag.

I have tested this change on Amazon MKS.


This change is Reviewable

@ahsanbarkati ahsanbarkati merged commit 8925049 into master Apr 30, 2021
@ahsanbarkati ahsanbarkati deleted the ahsan/sasl branch April 30, 2021 06:29
ahsanbarkati added a commit that referenced this pull request Apr 30, 2021
We used to support only the PLAIN mechanism for SASL in CDC-Kafka.
This commit adds support for SCRAM-SHA-256 and SCRAM-SHA-512.

(cherry picked from commit 8925049)
ahsanbarkati added a commit that referenced this pull request Apr 30, 2021
We used to support only the PLAIN mechanism for SASL in CDC-Kafka.
This commit adds support for SCRAM-SHA-256 and SCRAM-SHA-512.

(cherry picked from commit 8925049)
ahsanbarkati added a commit that referenced this pull request Apr 30, 2021
We used to support only the PLAIN mechanism for SASL in CDC-Kafka.
This commit adds support for SCRAM-SHA-256 and SCRAM-SHA-512.

(cherry picked from commit 8925049)
ahsanbarkati added a commit that referenced this pull request Apr 30, 2021
We used to support only the PLAIN mechanism for SASL in CDC-Kafka.
This commit adds support for SCRAM-SHA-256 and SCRAM-SHA-512.

(cherry picked from commit 8925049)
ahsanbarkati added a commit that referenced this pull request Apr 30, 2021
We used to support only the PLAIN mechanism for SASL in CDC-Kafka.
This commit adds support for SCRAM-SHA-256 and SCRAM-SHA-512.

(cherry picked from commit 8925049)
ahsanbarkati added a commit that referenced this pull request Apr 30, 2021
We used to support only the PLAIN mechanism for SASL in CDC-Kafka.
This commit adds support for SCRAM-SHA-256 and SCRAM-SHA-512.

(cherry picked from commit 8925049)
danielmai added a commit to dgraph-io/dgraph-docs that referenced this pull request Jul 14, 2021
Documents the new option sasl-mechanism under the kafka superflag.

This change was introduced in Dgraph v21.03.1 with PR dgraph-io/dgraph#7765.

Example:

    --kafka="...; sasl-mechanism=SCRAM-SHA-512"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants