fix: Prevent proposal from being dropped accidentally#7741
Merged
jarifibrahim merged 4 commits intomasterfrom Apr 26, 2021
Merged
fix: Prevent proposal from being dropped accidentally#7741jarifibrahim merged 4 commits intomasterfrom
jarifibrahim merged 4 commits intomasterfrom
Conversation
Each proposal in alpha has a unique key but this unique key is not guaranteed to be unique. We could end up creating duplicate keys and these duplicate keys would get ignored in the raft loop. This PR proposes a different way of creating the proposal keys so that they are always unique. Fixes - DGRAPH-3012
jarifibrahim
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
NamanJain8
approved these changes
Apr 21, 2021
NamanJain8
reviewed
Apr 21, 2021
Contributor
NamanJain8
left a comment
NamanJain8
left a comment
There was a problem hiding this comment.
Should we make this change in zero's unique key too?
NamanJain8
reviewed
Apr 21, 2021
Co-authored-by: Naman Jain <naman@dgraph.io>
Contributor
Author
@NamanJain8 zero doesn't get that many proposals so we wouldn't have the problem of duplicate keys. |
added 2 commits
April 26, 2021 15:04
danielmai
pushed a commit
that referenced
this pull request
May 13, 2021
Each proposal in alpha has a unique key but this unique key is not guaranteed to be unique. We could end up creating duplicate keys and these duplicate keys would get ignored in the raft loop. This PR proposes a different way of creating the proposal keys so that they are always unique. Fixes - DGRAPH-3012
danielmai
pushed a commit
that referenced
this pull request
May 13, 2021
Each proposal in alpha has a unique key but this unique key is not guaranteed to be unique. We could end up creating duplicate keys and these duplicate keys would get ignored in the raft loop. This PR proposes a different way of creating the proposal keys so that they are always unique. Fixes - DGRAPH-3012
This was referenced May 13, 2021
danielmai
pushed a commit
that referenced
this pull request
May 13, 2021
Each proposal in alpha has a unique key but this unique key is not guaranteed to be unique. We could end up creating duplicate keys and these duplicate keys would get ignored in the raft loop. This PR proposes a different way of creating the proposal keys so that they are always unique. Fixes - DGRAPH-3012
danielmai
pushed a commit
that referenced
this pull request
May 13, 2021
Each proposal in alpha has a unique key but this unique key is not guaranteed to be unique. We could end up creating duplicate keys and these duplicate keys would get ignored in the raft loop. This PR proposes a different way of creating the proposal keys so that they are always unique. Fixes - DGRAPH-3012
This was referenced May 13, 2021
slotlocker2
pushed a commit
that referenced
this pull request
May 13, 2021
Each proposal in alpha has a unique key but this unique key is not guaranteed to be unique. We could end up creating duplicate keys and these duplicate keys would get ignored in the raft loop. This PR proposes a different way of creating the proposal keys so that they are always unique. Fixes - DGRAPH-3012 Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io>
NamanJain8
pushed a commit
that referenced
this pull request
May 19, 2021
Each proposal in alpha has a unique key but this unique key is not guaranteed to be unique. We could end up creating duplicate keys and these duplicate keys would get ignored in the raft loop. This PR proposes a different way of creating the proposal keys so that they are always unique. Fixes - DGRAPH-3012 Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io>
danielmai
added a commit
that referenced
this pull request
May 20, 2021
Cherry-pick of #7741 to release/v20.11. Each proposal in alpha has a unique key but this unique key is not guaranteed to be unique. We could end up creating duplicate keys and these duplicate keys would get ignored in the raft loop. This PR proposes a different way of creating the proposal keys so that they are always unique. Fixes - DGRAPH-3012, CLOUD-376. Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io>
danielmai
added a commit
that referenced
this pull request
May 20, 2021
Cherry-pick of #7741 to release/v21.03. Each proposal in alpha has a unique key but this unique key is not guaranteed to be unique. We could end up creating duplicate keys and these duplicate keys would get ignored in the raft loop. This PR proposes a different way of creating the proposal keys so that they are always unique. Fixes - DGRAPH-3012, CLOUD-376. Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each proposal in alpha has a unique key but this unique key is not
guaranteed to be unique. We could end up creating duplicate keys and
these duplicate keys would get ignored in the raft loop.
This PR proposes a different way of creating the proposal keys so that
they are always unique.
Fixes - DGRAPH-3012
This change is