feat(flags): [Breaking] Add cache superflag for alpha#7652
feat(flags): [Breaking] Add cache superflag for alpha#7652NamanJain8 merged 5 commits intorelease/v21.03from
Conversation
rohanprasad
requested review from
manishrjain,
martinmr,
pawanrawal and
vvbalaji-dgraph
as code owners
rohanprasad
changed the title
NamanJain8
left a comment
NamanJain8
left a comment
There was a problem hiding this comment.
Looks good. Can you please verify if admin/config/cache_mb on alpha still works the same. It should work fine but should be good to confirm.
| "Total size of cache (in MB) to be used in Dgraph."). | ||
| Flag("percentage", | ||
| "Cache percentages summing up to 100 for various caches (FORMAT: PostingListCache,"+ | ||
| "PstoreBlockCache,PstoreIndexCache,WAL)"). |
There was a problem hiding this comment.
This needs to be changed. The pstoreblock cache and pstore index cache values are being fetched from the badger super flag. We don't need them over here.
Also, the wal is no longer supported.
@NamanJain8
There was a problem hiding this comment.
Removed the wal cache from flag. Also, we decided to keep the cache as it is.
manishrjain
left a comment
manishrjain
left a comment
There was a problem hiding this comment.
Let's use Badger SuperFlag correctly in Dgraph.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @martinmr, @NamanJain8, @pawanrawal, @rohanprasad, and @vvbalaji-dgraph)
NamanJain8
left a comment
NamanJain8
left a comment
There was a problem hiding this comment.
@manishrjain I will create a separate PR for badger flag changes.
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions (waiting on @martinmr, @NamanJain8, @pawanrawal, @rohanprasad, and @vvbalaji-dgraph)
This change introduces cache as a superflag, with size-mb and percentage as subflags for dgraph alphas.
5 participants
This change introduces cache as a superflag, with size-mb and percentage as subflags for dgraph alphas.
Fixes DGRAPH-3212
This change is