fix(Query): [Breaking] Return error for illegal math operations.#7631
Merged
rohanprasad merged 6 commits intorelease/v21.03from Mar 31, 2021
Merged
fix(Query): [Breaking] Return error for illegal math operations.#7631rohanprasad merged 6 commits intorelease/v21.03from
rohanprasad merged 6 commits intorelease/v21.03from
Conversation
09071e6 to
d0711a7
Compare
jarifibrahim
approved these changes
Mar 23, 2021
Contributor
jarifibrahim
left a comment
There was a problem hiding this comment.
Looks good to me. Defer to @ajeetdsouza for the final approval.
ajeetdsouza
previously requested changes
Mar 24, 2021
Contributor
ajeetdsouza
left a comment
There was a problem hiding this comment.
Create a table with the old and new behaviours of all the math operations we've changed, and notify the docs team.
ajeetdsouza
reviewed
Mar 26, 2021
aman-bansal
pushed a commit
that referenced
this pull request
Apr 8, 2021
* Return error if operand for math functions are invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an operand is passed to math operations like log (ln, logbase), sqrt, pow which might result in illegal operation (resulting in NaN) we return 0 instead of an error. This PR fixes that.
Fixes DGRAPH-3150
This change is