Fix(admin-endpoints): Error out if the request is rejected by the server#7511
Merged
ahsanbarkati merged 7 commits intomasterfrom Mar 3, 2021
Merged
Fix(admin-endpoints): Error out if the request is rejected by the server#7511ahsanbarkati merged 7 commits intomasterfrom
ahsanbarkati merged 7 commits intomasterfrom
Conversation
ahsanbarkati
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
NamanJain8
approved these changes
Mar 3, 2021
Contributor
NamanJain8
left a comment
NamanJain8
left a comment
There was a problem hiding this comment.
Few minor comments. Rest looks good.
aman-bansal
pushed a commit
that referenced
this pull request
Mar 9, 2021
…ver (#7511) A few admin endpoints such as /admin/shutdown, /admin/drain, admin/config sends a success response even if the server rejects the request. This change fixes this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few admin endpoints such as
/admin/shutdown,/admin/drain,admin/configsends a success response even if the server rejects the request. This PR fixes the issue.This change is