breaking(metrics): Rename Badger metrics.#7507
Merged
Conversation
This renames the Badger metrics in the /metrics endpoint to remove the Badger version in the metric names. This allows the metric name to remain the same across Badger major versions. | Previous Name | New Name | | ------------------------------- | ---------------------------- | | badger_v3_disk_reads_total | badger_disk_reads_total | | badger_v3_disk_writes_total | badger_disk_writes_total | | badger_v3_read_bytes | badger_read_bytes | | badger_v3_written_bytes | badger_written_bytes | | badger_v3_lsm_bloom_hits_total | badger_lsm_bloom_hits_total | | badger_v3_gets_total | badger_gets_total | | badger_v3_puts_total | badger_puts_total | | badger_v3_memtable_gets_total | badger_memtable_gets_toal | | badger_v3_lsm_size_bytes | badger_lsm_size_bytes | | badger_v3_vlog_size_bytes | badger_vlog_size_bytes |
manishrjain
approved these changes
Mar 3, 2021
Contributor
manishrjain
left a comment
manishrjain
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @vvbalaji-dgraph)
aman-bansal
pushed a commit
that referenced
this pull request
Mar 9, 2021
This renames the Badger metrics in the /metrics endpoint to remove the Badger version in the metric names. This allows the metric name to remain the same across Badger major versions. | Previous Name | New Name | | ------------------------------- | ---------------------------- | | badger_v3_disk_reads_total | badger_disk_reads_total | | badger_v3_disk_writes_total | badger_disk_writes_total | | badger_v3_read_bytes | badger_read_bytes | | badger_v3_written_bytes | badger_written_bytes | | badger_v3_lsm_bloom_hits_total | badger_lsm_bloom_hits_total | | badger_v3_gets_total | badger_gets_total | | badger_v3_puts_total | badger_puts_total | | badger_v3_memtable_gets_total | badger_memtable_gets_total | | badger_v3_lsm_size_bytes | badger_lsm_size_bytes | | badger_v3_vlog_size_bytes | badger_vlog_size_bytes |
danielmai
added a commit
to dgraph-io/dgraph-docs
that referenced
this pull request
Jun 4, 2021
This PR reflects the update to Dgraph metrics made in dgraph-io/dgraph#7507
MichelDiz
pushed a commit
to dgraph-io/dgraph-docs
that referenced
this pull request
Dec 15, 2022
This PR reflects the update to Dgraph metrics made in dgraph-io/dgraph#7507
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the Badger metrics in the /metrics endpoint to remove the
Badger version in the metric names. This allows the metric name to
remain the same across Badger major versions.
This change is