feat(flags): use Vault for ACL secrets#7492
Merged
ajeetdsouza merged 14 commits intomasterfrom Mar 8, 2021
Merged
Conversation
ajeetdsouza
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
jarifibrahim
reviewed
Mar 3, 2021
jarifibrahim
approved these changes
Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Dgraph only allows retrieving encryption keys from Vault. This PR adds suppport for ACL keys, as well. It also includes a refactor for the key handling code.
This change is