feat(GraphQL): Dgraph.Authorization should with irrespective of number of spaces after ##7410
Merged
minhaj-shakeel merged 7 commits intomasterfrom Feb 12, 2021
Merged
Conversation
minhaj-shakeel
requested review from
manishrjain,
pawanrawal and
vvbalaji-dgraph
as code owners
github-actions
Bot
added
the
area/graphql
pawanrawal
approved these changes
Feb 11, 2021
Contributor
pawanrawal
left a comment
pawanrawal
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain, @minhaj-shakeel, and @vvbalaji-dgraph)
graphql/schema/schemagen.go, line 188 at r1 (raw file):
continue } if !strings.HasPrefix(header, "Dgraph.Secret") {
Can we ensure that similar stuff also works for Dgraph.Secret?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GRAPHQ-960.
This PR ignores the spacing between
#andDgraph.Authorizationin the GraphQL schema. Now the user can give any number of spaces or no space between it. For example, the header#Dgraph.Authorization.....will also be valid which was earlier not the case.This change is