fix(graphQL): Validate subscriptions in Operation function (#5926)#5983
Merged
parasssh merged 1 commit intorelease/v20.07from Jul 14, 2020
Merged
fix(graphQL): Validate subscriptions in Operation function (#5926)#5983parasssh merged 1 commit intorelease/v20.07from
parasssh merged 1 commit intorelease/v20.07from
Conversation
We realised that as a result of b40c632, introspection queries started failing in Insomnia because subscription didn't exist in the types. Instead of adding more hacks there, we add validation for this inside Operation. We already do something similar for Queries/Mutations. (cherry picked from commit e33850e)
pawanrawal
changed the title
github-actions
Bot
added
the
area/graphql
Contributor
|
Please add the JIRA ticket in the description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We realised that as a result of b40c632, introspection queries started failing in Insomnia because subscription didn't exist in the types. Instead of adding more hacks there, we add validation for this inside Operation. We already do something similar for Queries/Mutations.
(cherry picked from commit e33850e)
This change is
Docs Preview: