Skip to content

Change groupId from int to uint32 in LoadBackup#5605

Merged
martinmr merged 1 commit intomasterfrom
martinmr/gid-uint32
Jun 9, 2020
Merged

Change groupId from int to uint32 in LoadBackup#5605
martinmr merged 1 commit intomasterfrom
martinmr/gid-uint32

Conversation

@martinmr
Copy link
Copy Markdown
Contributor

@martinmr martinmr commented Jun 8, 2020

This change removes the need to convert between int and uint32.
Group IDs are always uint32.


This change is Reviewable

This change removes the need to convert between int and uint32.
Group IDs are always uint32.
Copy link
Copy Markdown

@vvbalaji-dgraph vvbalaji-dgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@martinmr martinmr merged commit f2211c5 into master Jun 9, 2020
@martinmr martinmr deleted the martinmr/gid-uint32 branch June 9, 2020 19:16
martinmr added a commit that referenced this pull request Jun 9, 2020
This change removes the need to convert between int and uint32.
Group IDs are always uint32.
martinmr added a commit that referenced this pull request Jun 9, 2020
This change removes the need to convert between int and uint32.
Group IDs are always uint32.
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 18, 2020
This change removes the need to convert between int and uint32.
Group IDs are always uint32.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants